-
-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Better French translations in the menu item file #4711
Conversation
in order to stick with the original English meaning
Transifex should be used for these translations. |
You can build the |
I'm not a coder, hence I didn't understand what you said. |
Do you want to be? No hurries. |
Is the |
I don't think so.
Yes, hence my PR here. |
An answer would be appreciated. |
Depends what that means/involved in your sentence/POV. |
Since coding is fun, let us assume you want to be a coder; you can change your mind later. There are no deadlines. First goal is to build this Do you want to start solving the problem right away or do you want to train some skills first? |
I'll be AFK for the next 4 or 5 days.
You're the teacher, your call. 😉 |
Transifex is now pointing at master so we've accepted translation fixes against stable-1.2 here. |
@trebmuh, read Becoming a coder and try to complete the activities. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks fine for lmms-1.2 .
@liushuyu Is it too much work for two lines to have this merged in stable-1.2 and then updated on Transifex? We could refer this to master/Transifex directly but this is the new wording of the menu file and just looks better. |
Just my opinion: I believe this request is more useful if it is not merged yet. |
For 1.2, I vote for merging this. |
I'm for keeping the number of open PRs low (to not oversee PRs) and merging this one does not harm. If anyone wants a generator, I propose they set up a separate issue. Merging in 5 days if no one has objections (and I don't forget). |
@JohannesLorenz has this been merged and we can close this PR? |
Yes 😃 |
Thank you! |
@pikachuk The only way to fix this is by getting a Transifex account and editing it there. |
Nope, that's not the only way (or it shouldn't be). @liushuyu is usually managing to keep his github repo and the transifex one in sync. BTW it is unfortunate that a free software is kind of enforcing to use a non-free product to work on the translation. @liushuyu has been helping me on the last years so I can translate LMMS (soft + website) into French without giving information to yet another business non-free company. I would suggest to switch to Weblate here. |
Probably someone overrode your changes on Transifex.
Well, actually Transifex was releasing the source code of their website before they made their service as a kind of SaaS. |
The was is the point. Too bad. It seems to me that Weblate is still releasing its code under a free licence. |
in order to stick with the original English meaning
in order to stick with the original English meaning