Correct export of sampletracks at more than 44100 samplerate

[serdnab]

I created a new constructor for samplebuffer that sets a flag (m_fromSampleTrack) for samplebuffer objects that belongs to sample tracks.
When the samplerate of the mixer is changed, those objects have their samplerate changed accordingly.
This fixes the bad rendering of sample tracks at more than 44100 samplerate and, as a side effect it fixes #2778.

[PhysSong]

This fixes the bad rendering of sample tracks at more than 44100 samplerate

I think #5226 has fixed it.

it fixes #2778.

I'm not sure if it's already fixed or not. @Reflexe Are there any chances that #4991/#5226 has changed the behavior?

[LmmsBot]

🤖 Hey, I'm @LmmsBot from github.com/lmms/bot and I made downloads for this pull request, click me to make them magically appear! 🎩

Windows

• Windows 32-bit: lmms-1.2.1.546-mingw-win32.exe (build link)
• Windows 64-bit: lmms-1.2.1.546-mingw-win64.exe (build link)

Linux

• Linux (AppImage): lmms-1.2.1.546-linux-x86_64.AppImage (build link)

🤖

{"commit_sha": "8761af122486f6648ce2d2d6ef2d717861862a24", "platform_name_to_artifacts": {"Windows": [{"artifact": {"title": {"title": "32-bit", "platform_name": "Windows"}, "link": {"link": "https://4783-15778896-gh.circle-artifacts.com/0/lmms-1.2.1.546-mingw-win32.exe"}}, "build_link": "https://circleci.com/gh/LMMS/lmms/4783?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link"}, {"artifact": {"title": {"title": "64-bit", "platform_name": "Windows"}, "link": {"link": "https://4784-15778896-gh.circle-artifacts.com/0/lmms-1.2.1.546-mingw-win64.exe"}}, "build_link": "https://circleci.com/gh/LMMS/lmms/4784?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link"}], "Linux": [{"artifact": {"title": {"title": "(AppImage)", "platform_name": "Linux"}, "link": {"link": "https://4782-15778896-gh.circle-artifacts.com/0/lmms-1.2.1.546-linux-x86_64.AppImage"}}, "build_link": "https://circleci.com/gh/LMMS/lmms/4782?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link"}]}}

[zonkmachine]

I think #5224 has fixed it.

@PhysSong I think you meant #5226

[Reflexe]

This is strange. Can you elaborate about the problem you are trying to solve in this PR?

[serdnab]

Sorry, I didn't see that it was fixed (I didn't update my local repo in recent days), coincidence that we worked on the same.

[Reflexe]

Sorry, I didn't see that it was fixed (I didn't update my local repo in recent days), coincidence that we worked on the same.

Could you please verify the issue has been solved with #5226? Thanks!

[serdnab]

Could you please verify the issue has been solved with #5226?

Yes, it is. And also #2778.