Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes AutomationPattern to use nodes instead of raw float values #5712

Merged
merged 62 commits into from
Feb 28, 2021
Merged
Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
62 commits
Select commit Hold shift + click to select a range
77d69e2
First commit
IanCaio Oct 13, 2020
fb2107d
Implements inValue/outValue on Automation Nodes
IanCaio Oct 14, 2020
28611b8
Fixes and refactor code on AutomationEditor.cpp
IanCaio Oct 15, 2020
e5c9669
Avoids unnecessary check in putValue
IanCaio Oct 15, 2020
ab0aeb0
Adds upgrade routine for the automation nodes
IanCaio Oct 15, 2020
2ed2a66
Allows dragging outValues on the Automation Editor
IanCaio Oct 16, 2020
7b6729b
Small fix inside AutomationPattern.cpp
IanCaio Oct 16, 2020
a800943
Creates separate files for AutomationNode
IanCaio Oct 16, 2020
3932106
Adds more members to AutomationNode
IanCaio Oct 16, 2020
9f55d2c
Removes unused code from AutomationEditor
IanCaio Oct 16, 2020
c42c46b
Changes to the outValues now update the tangents
IanCaio Oct 16, 2020
504143c
Keeps discrete jumps when flipping patterns
IanCaio Oct 16, 2020
d67942b
Allows reseting outValues on the AutomationEditor
IanCaio Oct 16, 2020
7c269bd
Makes so dragging nodes keep the outValue
IanCaio Oct 16, 2020
64fcec0
Fixes code style on modified code
IanCaio Oct 16, 2020
578367e
Adds a QProperty for the node outValue color
IanCaio Oct 16, 2020
c4960a1
Adds doxygen comments on methods
IanCaio Oct 16, 2020
5c94591
Refactor flipX and flipY methods
IanCaio Oct 16, 2020
939596a
Add a new edit mode to Automation Editor
IanCaio Oct 16, 2020
5a38f74
Improves the Draw OutValue edit mode
IanCaio Oct 17, 2020
7925196
Adds mutex to AutomationPattern
IanCaio Oct 17, 2020
9e325dc
Veratil's review changes
IanCaio Oct 19, 2020
61d20ff
Changes the inValue sphere to be draw first
IanCaio Oct 19, 2020
ff92b56
Merge branch 'master' into feature/automationProgression
IanCaio Oct 21, 2020
3d4be23
Changes comments and variables names
IanCaio Oct 21, 2020
caa43ad
Changes QProperty variables to use MEMBER
IanCaio Oct 22, 2020
61ef27a
Overloads some AutomationNode's operators
IanCaio Oct 22, 2020
932a46e
Improves getNodeAt method
IanCaio Oct 22, 2020
a64942a
Changes behavior of setDragValue
IanCaio Oct 22, 2020
3b6f238
Moves getNodeAt to an upper level, reducing lines
IanCaio Oct 22, 2020
53f4afa
Changes icon of Draw OutValue edit mode
IanCaio Oct 22, 2020
108323d
Merge branch 'master' into feature/automationProgression
IanCaio Oct 24, 2020
203d3b5
Removes unnecessary non-const methods
IanCaio Nov 12, 2020
1531668
Merge branch 'master' into feature/automationProgression
IanCaio Nov 12, 2020
5184d79
Fixes formatting and doxygen comments
IanCaio Nov 13, 2020
9805321
Adds helper macros for AutomationNodes
IanCaio Nov 13, 2020
055c95f
Removes tabs from ternary operator
IanCaio Nov 13, 2020
1c3502c
Update files to use AutomationNode macros
IanCaio Nov 13, 2020
3471b8f
Merge branch 'master' into feature/automationProgression
IanCaio Nov 26, 2020
7559a41
Addresses my own code review
IanCaio Nov 26, 2020
2cf33e1
Addresses Veratil's review
IanCaio Nov 26, 2020
e0c3563
Adds helper MACROs for node tangents
IanCaio Nov 26, 2020
85a0ca3
Merge branch 'master' into feature/automationProgression
IanCaio Dec 5, 2020
cbf73dc
Fixes header inclusion order
IanCaio Dec 5, 2020
de6d7c9
Removes mutex from AutomationEditor
IanCaio Dec 6, 2020
7d1f196
Locks mutex on AutomationPattern copy assignment
IanCaio Dec 6, 2020
128c723
Changes resetOutValue() so it generates tangents
IanCaio Dec 6, 2020
adc223b
Changes some methods to use for loops
IanCaio Dec 11, 2020
169cc3b
Move removeNodes/resetNodes to AutomationPattern
IanCaio Dec 11, 2020
033bfab
Optimizes loop inside putValue/putValues
IanCaio Dec 11, 2020
fe53845
Adds comment to mysterious calculation
IanCaio Dec 12, 2020
1f28a45
Merge branch 'master' into feature/automationProgression
IanCaio Dec 16, 2020
1e1e5f8
Reduces indentation on getNodeAt
IanCaio Dec 16, 2020
6bec055
Applies Veratil suggestions
IanCaio Dec 16, 2020
1d23334
Updates comment from changed code
IanCaio Dec 16, 2020
8c5f9d4
Uses lambda functions to extract code
IanCaio Dec 16, 2020
1d1d57c
Fixes behavior of AutomationPattern::flipX
IanCaio Dec 20, 2020
d9862c5
Changes pattern XML for backwards compatibility
IanCaio Dec 20, 2020
2d1fbd0
Fixes bug on AutomationPattern::resetNodes
IanCaio Dec 20, 2020
4b4ac2b
Adds comment about copy-assignment
IanCaio Jan 7, 2021
93c0c65
Merge branch 'master' into feature/automationProgression
IanCaio Jan 30, 2021
5a66667
Changes flipY logic and address PhysSong review
IanCaio Jan 30, 2021
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions include/AutomationEditor.h
Original file line number Diff line number Diff line change
Expand Up @@ -131,6 +131,10 @@ public slots:
void selectAll();
void getSelectedValues(timeMap & selected_values );

// Returns the an iterator pointing to the AutomationNode on a radius of
IanCaio marked this conversation as resolved.
Show resolved Hide resolved
// r pixels of the x,y mouse coordinates, or timeMap.end() if there are none.
timeMap::iterator getNodeAt( int x, int y, int r = 5 );

void drawLine( int x0, float y0, int x1, float y1 );
void removePoints( int x0, int x1 );

Expand Down Expand Up @@ -167,6 +171,7 @@ protected slots:
{
NONE,
MOVE_VALUE,
DRAW_LINE,
SELECT_VALUES,
MOVE_SELECTION
} ;
Expand Down
86 changes: 73 additions & 13 deletions include/AutomationPattern.h
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,77 @@ class MidiTime;



class AutomationNode
Veratil marked this conversation as resolved.
Show resolved Hide resolved
{
public:
AutomationNode();
AutomationNode( float value );
AutomationNode( float inValue, float outValue );

inline float getInValue()
{
return m_inValue;
}
inline const float getInValue() const
{
return m_inValue;
}
inline void setInValue( float value )
{
m_inValue = value;
}

inline float getOutValue()
{
return m_outValue;
}
inline const float getOutValue() const
{
return m_outValue;
}
inline void setOutValue( float value )
{
m_outValue = value;
}

inline float getInTangent()
{
return m_inTangent;
}
inline const float getInTangent() const
{
return m_inTangent;
}
inline void setInTangent( float tangent )
{
m_inTangent = tangent;
}

inline float getOutTangent()
{
return m_outTangent;
}
inline const float getOutTangent() const
{
return m_outTangent;
}
inline void setOutTangent( float tangent )
{
m_outTangent = tangent;
}

private:
float m_inValue;
float m_outValue;

// Slope at each point for calculating spline
// We might have discrete jumps between curves, so we possibly have
// two different tangents for each side of the curve. If inValue and
// outValue are equal, inTangent and outTangent are equal too.
float m_inTangent;
float m_outTangent;
} ;

class LMMS_EXPORT AutomationPattern : public TrackContentObject
{
Q_OBJECT
Expand All @@ -49,7 +120,7 @@ class LMMS_EXPORT AutomationPattern : public TrackContentObject
CubicHermiteProgression
} ;

typedef QMap<int, float> timeMap;
typedef QMap<int, AutomationNode> timeMap;
typedef QVector<QPointer<AutomatableModel> > objectVector;

AutomationPattern( AutomationTrack * _auto_track );
Expand Down Expand Up @@ -109,16 +180,6 @@ class LMMS_EXPORT AutomationPattern : public TrackContentObject
return m_timeMap;
}

inline const timeMap & getTangents() const
{
return m_tangents;
}

inline timeMap & getTangents()
{
return m_tangents;
}

inline float getMin() const
{
return firstObject()->minValue<float>();
Expand Down Expand Up @@ -170,15 +231,14 @@ public slots:
private:
void cleanObjects();
void generateTangents();
void generateTangents( timeMap::const_iterator it, int numToGenerate );
void generateTangents( timeMap::iterator it, int numToGenerate );
float valueAt( timeMap::const_iterator v, int offset ) const;

AutomationTrack * m_autoTrack;
QVector<jo_id_t> m_idsToResolve;
objectVector m_objects;
timeMap m_timeMap; // actual values
timeMap m_oldTimeMap; // old values for storing the values before setDragValue() is called.
timeMap m_tangents; // slope at each point for calculating spline
float m_tension;
bool m_hasAutomation;
ProgressionTypes m_progressionType;
Expand Down
5 changes: 3 additions & 2 deletions include/InlineAutomation.h
Original file line number Diff line number Diff line change
Expand Up @@ -57,8 +57,9 @@ class InlineAutomation : public FloatModel, public sharedObject
// of model which is going to be saved anyways
if( isAtInitValue() &&
m_autoPattern->getTimeMap().size() == 1 &&
m_autoPattern->getTimeMap().keys().first() == 0 &&
m_autoPattern->getTimeMap().values().first() == value() )
m_autoPattern->getTimeMap().begin().key() == 0 &&
// TODO: Do we really care about outValue if we only have one node? I'm assuming no.
m_autoPattern->getTimeMap().begin().value().getInValue() == value() )
{
return false;
}
Expand Down
Loading