Color mixer channels if they are made by a colored track

[ryuukumar]

Don't merge yet. There's discussion going on in #5778 on whether this is a needed feature, I'll merge this/work a bit more on it if consensus is reached.

Closes #5778.

This PR implements the functionality to color the new mixer tracks generated by the 'Assign to new FX channel' option.

Demo

[LmmsBot]

🤖 Hey, I'm @LmmsBot from github.com/lmms/bot and I made downloads for this pull request, click me to make them magically appear! 🎩

Linux

• Linux (AppImage): lmms-1.3.0-alpha.1.7%2Bg8fd3783-linux-x86_64.AppImage (build link)

Windows

• Windows 32-bit: lmms-1.3.0-alpha.1.7%2Bg8fd3783ce-mingw-win32.exe (build link)
• Windows 64-bit: lmms-1.3.0-alpha.1.7%2Bg8fd3783ce-mingw-win64.exe (build link)
• Windows 32-bit: lmms-1.3.0-alpha-msvc2017-win32.exe (build link)
• Windows 64-bit: lmms-1.3.0-alpha-msvc2017-win64.exe (build link)

macOS

• macOS : lmms-1.3.0-alpha.1.7%2Bg8fd3783ce-mac10.13.dmg (build link)

🤖

{"platform_name_to_artifacts": {"Linux": [{"artifact": {"title": {"title": "(AppImage)", "platform_name": "Linux"}, "link": {"link": "https://10308-15778896-gh.circle-artifacts.com/0/lmms-1.3.0-alpha.1.7%2Bg8fd3783-linux-x86_64.AppImage"}}, "build_link": "https://circleci.com/gh/LMMS/lmms/10308?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link"}], "Windows": [{"artifact": {"title": {"title": "32-bit", "platform_name": "Windows"}, "link": {"link": "https://10306-15778896-gh.circle-artifacts.com/0/lmms-1.3.0-alpha.1.7%2Bg8fd3783ce-mingw-win32.exe"}}, "build_link": "https://circleci.com/gh/LMMS/lmms/10306?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link"}, {"artifact": {"title": {"title": "64-bit", "platform_name": "Windows"}, "link": {"link": "https://10305-15778896-gh.circle-artifacts.com/0/lmms-1.3.0-alpha.1.7%2Bg8fd3783ce-mingw-win64.exe"}}, "build_link": "https://circleci.com/gh/LMMS/lmms/10305?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link"}, {"artifact": {"title": {"title": "32-bit", "platform_name": "Windows"}, "link": {"link": "https://ci.appveyor.com/api/buildjobs/l6189k5urbnum20u/artifacts/build/lmms-1.3.0-alpha-msvc2017-win32.exe"}}, "build_link": "https://ci.appveyor.com/project/Lukas-W/lmms/builds/36251728"}, {"artifact": {"title": {"title": "64-bit", "platform_name": "Windows"}, "link": {"link": "https://ci.appveyor.com/api/buildjobs/b6nlkho4yrhqj8ry/artifacts/build/lmms-1.3.0-alpha-msvc2017-win64.exe"}}, "build_link": "https://ci.appveyor.com/project/Lukas-W/lmms/builds/36251728"}], "macOS": [{"artifact": {"title": {"title": "", "platform_name": "macOS"}, "link": {"link": "https://10307-15778896-gh.circle-artifacts.com/0/lmms-1.3.0-alpha.1.7%2Bg8fd3783ce-mac10.13.dmg"}}, "build_link": "https://circleci.com/gh/LMMS/lmms/10307?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link"}]}, "commit_sha": "6cd1bbd14062613a08145afaceeeb829eb1f2f41"}

[Gabrielxd195]

I just tested the upgrade you made and I see that everything works fine. now the color is assigned automatically. Thank you

[ryuukumar]

Great, thanks for testing!

Could anybody glance at the code for this? It's 13 lines, should (hopefully) be quick.

Note about the style: As discussed in #5765, I have used the new code style here. Please refer to the conversation over there for why it was done.

[superpaik]

Tested ok.

[ryuukumar]

Thanks for the testing, @Gabrielxd195 and @superpaik! If @IanCaio approves, I think this will be good to go.

[ryuukumar]

It appears that there is quite some discussion over at #5778. I’ll hold this one out until there’s a consensus, and if everyone agrees to have this merge, I’ll merge it.

[Spekular]

LGTM and not opposed to this implementation (see #5778 (comment))

[ryuukumar]

Alright, it seems consensus in favour of this has been reached. Merging this.