Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #5840 #5844

Merged
merged 1 commit into from
Dec 13, 2020
Merged

Fix #5840 #5844

merged 1 commit into from
Dec 13, 2020

Conversation

Spekular
Copy link
Member

No description provided.

@LmmsBot
Copy link

LmmsBot commented Dec 12, 2020

🤖 Hey, I'm @LmmsBot from github.com/lmms/bot and I made downloads for this pull request, click me to make them magically appear! 🎩

Linux

Windows

🤖
{"platform_name_to_artifacts": {"Linux": [{"artifact": {"title": {"title": "(AppImage)", "platform_name": "Linux"}, "link": {"link": "https://11581-15778896-gh.circle-artifacts.com/0/lmms-1.3.0-alpha.1.48%2Bg2496b4b-linux-x86_64.AppImage"}}, "build_link": "https://circleci.com/gh/LMMS/lmms/11581?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link"}], "Windows": [{"artifact": {"title": {"title": "32-bit", "platform_name": "Windows"}, "link": {"link": "https://11584-15778896-gh.circle-artifacts.com/0/lmms-1.3.0-alpha.1.48%2Bg2496b4b95-mingw-win32.exe"}}, "build_link": "https://circleci.com/gh/LMMS/lmms/11584?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link"}, {"artifact": {"title": {"title": "64-bit", "platform_name": "Windows"}, "link": {"link": "https://11580-15778896-gh.circle-artifacts.com/0/lmms-1.3.0-alpha.1.48%2Bg2496b4b95-mingw-win64.exe"}}, "build_link": "https://circleci.com/gh/LMMS/lmms/11580?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link"}, {"artifact": {"title": {"title": "32-bit", "platform_name": "Windows"}, "link": {"link": "https://ci.appveyor.com/api/buildjobs/yuoopqkcovpfdcqg/artifacts/build/lmms-1.3.0-alpha-msvc2017-win32.exe"}}, "build_link": "https://ci.appveyor.com/project/Lukas-W/lmms/builds/36803760"}, {"artifact": {"title": {"title": "64-bit", "platform_name": "Windows"}, "link": {"link": "https://ci.appveyor.com/api/buildjobs/35h5x71ivfpv11d2/artifacts/build/lmms-1.3.0-alpha-msvc2017-win64.exe"}}, "build_link": "https://ci.appveyor.com/project/Lukas-W/lmms/builds/36803760"}, {"artifact": {"title": {"title": "32-bit", "platform_name": "Windows"}, "link": {"link": "https://ci.appveyor.com/api/buildjobs/xh7nd3klfr521yns/artifacts/build/lmms-1.3.0-alpha-msvc2017-win32.exe"}}, "build_link": "https://ci.appveyor.com/project/Lukas-W/lmms/builds/36803762"}, {"artifact": {"title": {"title": "64-bit", "platform_name": "Windows"}, "link": {"link": "https://ci.appveyor.com/api/buildjobs/25habj7n8b5ff46o/artifacts/build/lmms-1.3.0-alpha-msvc2017-win64.exe"}}, "build_link": "https://ci.appveyor.com/project/Lukas-W/lmms/builds/36803762"}]}, "commit_sha": "2496b4b959dd33b9c10f88229804722df223cd2e"}

Copy link
Contributor

@IanCaio IanCaio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

You have to buy me a beer after such a long review 😆

@zonkmachine
Copy link
Member

There's still odd things going on. I'll investigate this some more.

@zonkmachine
Copy link
Member

This PR fixes the problem reported in #5840.

There are other issues described in the comment section of #5840 which may or may not be related to the original issue.

@Spekular
Copy link
Member Author

Doubly approved oneliner, Mac CI failure is unrelated, merging.

@Spekular Spekular merged commit 09ee5c7 into master Dec 13, 2020
@Spekular Spekular deleted the fix-5840 branch December 13, 2020 15:41
IanCaio pushed a commit to IanCaio/lmms that referenced this pull request Mar 28, 2021
If copying to another track, allow same start and end position.
devnexen pushed a commit to devnexen/lmms that referenced this pull request Apr 10, 2021
If copying to another track, allow same start and end position.
sdasda7777 pushed a commit to sdasda7777/lmms that referenced this pull request Jun 28, 2022
If copying to another track, allow same start and end position.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants