Improve performance and quality of Sample Track display, and add RMS graph.

data/themes/classic/style.css

@@ -675,8 +675,8 @@ PatternView {
 
 /* sample track pattern */
 SampleTCOView {
-	background-color: rgb( 74, 253, 133 );
-	color: rgb( 187, 227, 236 );
+	background-color: rgba(42,51,59,255);
+	color: #FF8F05;
 }
 
 /* automation pattern */

data/themes/default/style.css

@@ -721,8 +721,8 @@ PatternView {
 
 /* sample track pattern */
 SampleTCOView {
-	background-color: #DE7C05;
-	color: #FFE8CD;
+	background-color: rgba(42,51,59,255);
+	color: #FF8F05;
 }
 
 /* automation pattern */

src/core/SampleBuffer.cpp

@@ -1017,30 +1017,57 @@ void SampleBuffer::visualize(
 	const float ySpace = h * 0.5f;
 	const int nbFrames = focusOnRange ? toFrame - fromFrame : m_frames;
 
-	const int fpp = qBound<int>(1, nbFrames / w, 20);
-	QPointF * l = new QPointF[nbFrames / fpp + 1];
-	QPointF * r = new QPointF[nbFrames / fpp + 1];
-	int n = 0;
+	const int fpp = qMax<int>(1, nbFrames / w);
+	const int totalPoints = nbFrames / fpp * 2 + 2;
+	std::vector<QPointF> fMax(totalPoints);
+	std::vector<QPointF> fRms(totalPoints);
+	int curFrame = 0;
 	const int xb = dr.x();
 	const int first = focusOnRange ? fromFrame : 0;
 	const int last = focusOnRange ? toFrame - 1 : m_frames - 1;
 
 	for (int frame = first; frame <= last; frame += fpp)
 	{
+		float maxData = -1;
+		float minData = 1;
+
+		float rmsData[2] = {0, 0};
+
+		// Find maximum and minimum samples within range
+		for (int i = 0; i < fpp && frame + i < last; ++i)
+		{
+			for (int j = 0; j < 2; ++j)
+			{
+				auto curData = m_data[frame + i][j];
+
+				if (curData > maxData) { maxData = m_data[frame + i][j]; }
+				if (curData < minData) { minData = m_data[frame + i][j]; }
+
+				rmsData[j] += curData * curData;
+			}
+		}
+
+		const float trueRmsData = (rmsData[0] + rmsData[1]) * 0.5 / fpp;
+		const float sqrtRmsData = sqrt(trueRmsData);
+		const float maxRmsData = qBound(minData, sqrtRmsData, maxData);
+		const float minRmsData = qBound(minData, -sqrtRmsData, maxData);
+
 		auto x = xb + ((frame - first) * double(w) / nbFrames);
 		// Partial Y calculation
 		auto py = ySpace * m_amplification;
-		l[n] = QPointF(x, (yb - (m_data[frame][0] * py)));
-		r[n] = QPointF(x, (yb - (m_data[frame][1] * py)));
-		++n;
+		fMax[curFrame*2] = QPointF(x, (yb - (maxData * py)));
+		fMax[curFrame*2+1] = QPointF(x, (yb - (minData * py)));
+		fRms[curFrame*2] = QPointF(x, (yb - (maxRmsData * py)));
+		fRms[curFrame*2+1] = QPointF(x, (yb - (minRmsData * py)));
+		++curFrame;
 	}
 
-	p.setRenderHint(QPainter::Antialiasing);
-	p.drawPolyline(l, nbFrames / fpp);
-	p.drawPolyline(r, nbFrames / fpp);
+	//p.setRenderHint(QPainter::Antialiasing);
+	p.drawPolyline(fMax.data(), totalPoints);
+
+	p.setPen(p.pen().color().lighter(123));//
 
-	delete[] l;
-	delete[] r;
+	p.drawPolyline(fRms.data(), totalPoints);
 }
 
 

src/tracks/SampleTrack.cpp

@@ -574,9 +574,13 @@ void SampleTCOView::paintEvent( QPaintEvent * pe )
 
 	QPainter p( &m_paintPixmap );
 
-	QLinearGradient lingrad( 0, 0, 0, height() );
-	QColor c = getColorForDisplay( painter.background().color() );
 	bool muted = m_tco->getTrack()->isMuted() || m_tco->isMuted();
+	bool selected = isSelected();
+
+	QLinearGradient lingrad( 0, 0, 0, height() );
+	QColor c = painter.background().color();
+	if (muted) { c = c.darker(150); }
+	if (selected) { c = c.darker(150); }
 
 	lingrad.setColorAt( 1, c.darker( 300 ) );
 	lingrad.setColorAt( 0, c );
@@ -593,7 +597,24 @@ void SampleTCOView::paintEvent( QPaintEvent * pe )
 		p.fillRect( rect(), c );
 	}
 
-	p.setPen( !muted ? painter.pen().brush().color() : mutedColor() );
+	auto tcoColor = m_tco->hasColor()
+			? (m_tco->usesCustomClipColor()
+				? m_tco->color()
+				: m_tco->getTrack()->color())
+			: painter.pen().brush().color();
+
+	p.setPen( tcoColor );
+
+	if (muted)
+	{
+		QColor penColor = p.pen().brush().color();
+		penColor.setHsv( penColor.hsvHue(), penColor.hsvSaturation() / 4, penColor.value() );
+		p.setPen(penColor.darker(250));
+	}
+	if (selected)
+	{
+		p.setPen(p.pen().brush().color().darker(150));
+	}
 
 	const int spacing = TCO_BORDER_WIDTH + 1;
 	const float ppb = fixedTCOs() ?