Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename TCO and related to Clip #6044

Closed
wants to merge 9 commits into from
Closed

Conversation

ryuukumar
Copy link
Member

@ryuukumar ryuukumar commented Jun 6, 2021

Don't merge yet, still in progress.

This is a part of #5592, an effort to reorganise and rename LMMS files and classes. This is the final version of this PR. Strongly urge to merge this as early as possible after it is marked complete so that there aren't too many merge conflicts to deal with.

I am yet to rename BB -> Pattern and other similar changes as described in the main issue.

Detailed list of renames:

  • TrackContentObject, TCO, Tco, tco -> Clip
  • TrackContentObjectView, TCOView (and other variables) -> ClipView
  • AutomationPattern, AutomationPatternView -> AutomationClip, AutomationClipView
  • Pattern -> MidiClip
  • BBTCO/BBClip -> PatternClip

@ryuukumar ryuukumar changed the title Clip rename Rename TCO and related to Clip Jun 6, 2021
@LmmsBot
Copy link

LmmsBot commented Jun 8, 2021

🤖 Hey, I'm @LmmsBot from github.com/lmms/bot and I made downloads for this pull request, click me to make them magically appear! 🎩

Linux

Windows

macOS

🤖
{"platform_name_to_artifacts": {"Linux": [{"artifact": {"title": {"title": "(AppImage)", "platform_name": "Linux"}, "link": {"link": "https://14107-15778896-gh.circle-artifacts.com/0/lmms-1.3.0-alpha.1.127%2Bg26309a0-linux-x86_64.AppImage"}}, "build_link": "https://circleci.com/gh/LMMS/lmms/14107?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link"}], "Windows": [{"artifact": {"title": {"title": "32-bit", "platform_name": "Windows"}, "link": {"link": "https://14109-15778896-gh.circle-artifacts.com/0/lmms-1.3.0-alpha.1.127%2Bg26309a09c-mingw-win32.exe"}}, "build_link": "https://circleci.com/gh/LMMS/lmms/14109?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link"}, {"artifact": {"title": {"title": "64-bit", "platform_name": "Windows"}, "link": {"link": "https://14110-15778896-gh.circle-artifacts.com/0/lmms-1.3.0-alpha.1.127%2Bg26309a09c-mingw-win64.exe"}}, "build_link": "https://circleci.com/gh/LMMS/lmms/14110?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link"}, {"artifact": {"title": {"title": "32-bit", "platform_name": "Windows"}, "link": {"link": "https://ci.appveyor.com/api/buildjobs/mdn75vvg7yv4v5ld/artifacts/build/lmms-1.3.0-alpha-msvc2017-win32.exe"}}, "build_link": "https://ci.appveyor.com/project/Lukas-W/lmms/builds/39746289"}, {"artifact": {"title": {"title": "64-bit", "platform_name": "Windows"}, "link": {"link": "https://ci.appveyor.com/api/buildjobs/4sfp9pe0f0x72a1p/artifacts/build/lmms-1.3.0-alpha-msvc2017-win64.exe"}}, "build_link": "https://ci.appveyor.com/project/Lukas-W/lmms/builds/39746289"}], "macOS": [{"artifact": {"title": {"title": "", "platform_name": "macOS"}, "link": {"link": "https://14108-15778896-gh.circle-artifacts.com/0/lmms-1.3.0-alpha.1.127%2Bg26309a09c-mac10.14.dmg"}}, "build_link": "https://circleci.com/gh/LMMS/lmms/14108?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link"}]}, "commit_sha": "385c0874d61e027487d36cff71808621a3c38d79"}

@ryuukumar ryuukumar marked this pull request as draft June 8, 2021 04:19
@ryuukumar
Copy link
Member Author

I have been inactive on this PR for a good few months now, and I don't think that I will be available to work on it until mid next year. It would be wrong of me hold up the reorg, and besides this is probably not up to date with newer changes. So, I am closing this PR to stop stalling the reorg efforts.

Feel free to base off this PR if you want a starting point for a newer renaming PR.

@M374LX
Copy link
Contributor

M374LX commented Nov 28, 2021

Superseded by #6226.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants