Fix waveshaping in DynamicsProcessor #7013
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
szeli1
changed the title
|
test file: |
sakertooth
reviewed
Mar 23, 2024
Co-authored-by: saker <sakertooth@gmail.com>
Co-authored-by: saker <sakertooth@gmail.com>
Co-authored-by: saker <sakertooth@gmail.com>
Co-authored-by: saker <sakertooth@gmail.com>
Co-authored-by: saker <sakertooth@gmail.com>
sakertooth
reviewed
Mar 23, 2024
sakertooth
reviewed
Mar 24, 2024
Co-authored-by: saker <sakertooth@gmail.com>
Co-authored-by: saker <sakertooth@gmail.com>
sakertooth
previously approved these changes
Mar 26, 2024
sakertooth
changed the title
sakertooth
dismissed
their stale review
Improper fix, DynamicsProcessor and its calculations needs to be fundamentally fixed to resolve this issue properly.
|
Closing in favor of #7168 (apologies for having you go through all of that, but a more proper solution seems to have been found). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #1581
With this change the DynamicsProcessor plugin/effect will cause much less waveshaping.
This picture shows the difference in the output volume and the fft between the original (version 1.2.2) and the changed version.
(keep in mind that the noise shown in the new version is because of clamping(?))