-
-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add native system semaphore and Windows shared memory #7212
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nothing stands out. Haven't tested but LGTM.
Yes, finally. Don't know what to test or review for in this but I'm glad to help here. |
A user on discord has stated that CPU usage has increased in the nightly builds when using VSTs compared to 1.2. Is this a regression from this change? |
I don't know - there's so little information about the problem and so many changes since 1.2 that there's no way to confidently answer with "yes" or "no". However, it seems unlikely to me, given that the only code in this PR that runs many times per second (in particular, acquiring and releasing semaphores) is very simple. If they are automating VST parameters, then the likely cause is #5321, which is a known issue. That feature is difficult to implement efficiently with the current IPC system, which is why I'm working on #6511. Otherwise, we need more information and more careful investigation. |
The primary goal here is to eliminate the Qt requirement for RemoteVstPlugin. This helps compatibility with Qt 6, which does not provide 32-bit binaries any more. It also helps with the more general effort to remove Qt from the core, and simplifies the CMake scripts for RemoteVstPlugin a bit. RemoteZynAddSubFx still needs Qt for XML processing, but that can be dealt with separately.
Changes: