Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Delete Confirmation Button Regression #7608

Merged
merged 1 commit into from
Nov 30, 2024

Conversation

regulus79
Copy link
Contributor

This pr fixes the buttons in the QMessageBox when you delete a track or a mixer channel to use the default style instead of inheriting the QPushButton style from the parent object. This is done by passing a nullptr as the parent to the constructor (or not passing anything at all).

There are other places in the lmms codebase where QMessageBox is used but the parent is not nullptr (in LOMM, AudioJack, MidiJack, MainWindow, MicrotunerConfig, ControllerConnectionDialog, and ExportProjectDialog). However, I don't believe any of them are experiencing any visual issues currently. I only fixed these two because they were noticeable.

Before:
Screenshot From 2024-11-29 12-44-25

After:
Screenshot From 2024-11-29 17-17-08

Copy link
Contributor

@Rossmaxx Rossmaxx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Haven't tested, but LGTM.

Copy link
Contributor

@sakertooth sakertooth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested. The message box looks better when removing tracks again, though I didn't see any change with removing mixer channels (it was already good to begin with for me, maybe someone else had a different experience though) 👍

@sakertooth sakertooth merged commit e311832 into LMMS:master Nov 30, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants