Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revamp searching in the file browser #7679

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 1 addition & 8 deletions include/FileBrowser.h
Original file line number Diff line number Diff line change
Expand Up @@ -29,9 +29,7 @@
#include <QDir>
#include <QMutex>
#include <QProgressBar>
#include <memory>

#include "FileSearch.h"
#include "embed.h"

#if (QT_VERSION >= QT_VERSION_CHECK(5,14,0))
Expand Down Expand Up @@ -106,10 +104,7 @@ private slots:
void saveDirectoriesStates();
void restoreDirectoriesStates();

void foundSearchMatch(FileSearch* search, const QString& match);
void searchCompleted(FileSearch* search);
void onSearch(const QString& filter);
void displaySearch(bool on);

void addContentCheckBox();

Expand All @@ -118,7 +113,6 @@ private slots:

QLineEdit * m_filterEdit;

std::shared_ptr<FileSearch> m_currentSearch;
QProgressBar* m_searchIndicator = nullptr;

QString m_directories; //!< Directories to search, split with '*'
Expand Down Expand Up @@ -204,7 +198,7 @@ private slots:
class Directory : public QTreeWidgetItem
{
public:
Directory(const QString& filename, const QString& path, const QString& filter, bool disableEntryPopulation = false);
Directory(const QString& filename, const QString& path, const QString& filter);

void update();

Expand Down Expand Up @@ -247,7 +241,6 @@ class Directory : public QTreeWidgetItem
QString m_filter;

int m_dirCount;
bool m_disableEntryPopulation = false;
} ;


Expand Down
73 changes: 0 additions & 73 deletions include/FileSearch.h

This file was deleted.

1 change: 0 additions & 1 deletion src/core/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,6 @@ set(LMMS_SRCS
core/Engine.cpp
core/EnvelopeAndLfoParameters.cpp
core/fft_helpers.cpp
core/FileSearch.cpp
core/Mixer.cpp
core/ImportFilter.cpp
core/InlineAutomation.cpp
Expand Down
92 changes: 0 additions & 92 deletions src/core/FileSearch.cpp

This file was deleted.

Loading
Loading