Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supersedes:
Originally, the intention in #4067 was to fix Qt detection for all platforms, however due to a multitude of reasons, I don't think that's practical due to:
So, instead, I'll focus on macOS, that's historically always had to use
CMAKE_PREFIX_PATH=$(brew --prefix qt@5)
(which as a macOS user, I'm always forgetting to type before running cmake).I've chosen to leverage
Qt5_DIR
andQt5Test_DIR
for simplicity, since the shell commands add much more conditional logic that's not necessarily warranted.I've added future support for Qt6.