Skip to content
This repository was archived by the owner on Nov 17, 2023. It is now read-only.

fix(wallet): phots to ltc conversion #1347

Merged
merged 1 commit into from
Jan 15, 2019
Merged

fix(wallet): phots to ltc conversion #1347

merged 1 commit into from
Jan 15, 2019

Conversation

mrfelton
Copy link
Member

Description:

Allow for phots to ltc conversion

Motivation and Context:

Fix #1345

How Has This Been Tested?

  1. Connect to litecoin node
  2. Navigate to Request form
  3. Set currency unit to photons
  4. Enter a value in the amount field
  5. Change currency unit to LTC

Ensure that correct conversion happens (previously would result in an error)

Types of changes:

Bug fix

Checklist:

  • My code follows the code style of this project.
  • I have reviewed and updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes where needed.
  • All new and existing tests passed.
  • My commits have been squashed into a concise set of changes.

@mrfelton mrfelton added the type: bug 🐛 Something isn't working label Jan 15, 2019
@mrfelton mrfelton added this to the v0.3.3-beta milestone Jan 15, 2019
@mrfelton mrfelton self-assigned this Jan 15, 2019
@mrfelton mrfelton requested review from JimmyMow and korhaliv January 15, 2019 08:03
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.05%) to 18.646% when pulling 71320c9 on mrfelton:fix/phots-to-ltc into b1ea05e on LN-Zap:master.

@mrfelton mrfelton requested a review from lieteau2 January 15, 2019 08:19
@mrfelton mrfelton merged commit 9126e5a into LN-Zap:master Jan 15, 2019
@mrfelton mrfelton deleted the fix/phots-to-ltc branch January 15, 2019 15:31
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@JimmyMow JimmyMow Awaiting requested review from JimmyMow

@lieteau2 lieteau2 Awaiting requested review from lieteau2

1 more reviewer

@korhaliv korhaliv korhaliv approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@mrfelton mrfelton

Labels
type: bug 🐛 Something isn't working
Projects
None yet
Milestone
v0.3.3-beta
Development

Successfully merging this pull request may close these issues.

bits/phots to ltc conversion missing?
3 participants
@mrfelton @coveralls @korhaliv