This repository has been archived by the owner on Nov 17, 2023. It is now read-only.
fix(wallet): show as unconfirmed transactions #1348
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrfelton
added
type: bug 🐛
korhaliv
approved these changes
Jan 15, 2019
|
@mrfelton this may be picky but the copy still may be a bit misleading/weird. If it is unconfirmed what about |
Show unconfirmed transactions as "Unconfirmed" rather than being in block 0. Fix LN-Zap#1344
mrfelton
force-pushed
the
fix/transaction-modal
branch
from
a12df80 to
6959f26
Compare
|
I've updated that @JimmyMow
|
|
Nice. ACK from me |
JimmyMow
approved these changes
Jan 15, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Show unconfirmed transactions as "Unconfirmed" rather than being in block 0.
Motivation and Context:
Fix #1344
How Has This Been Tested?
Send an onchain transaction and then view the transaction in the transaction modal right after sending. Should show as
Confirmed in Block: Unconfirmedrather thanConfirmed in Block: 0Screenshots (if appropriate):
Before:
After:
Types of changes:
Bug fix
Checklist: