This repository has been archived by the owner on Nov 17, 2023. It is now read-only.
build(electron): exclude node modules from production app #1939
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Since flattening the repo in #1895 the linux builds have been broken. On investigation I've discovered that it's attempting to package a bunch of node_modules that it should not be.
By default, electron-builder packages app production dependencies and ignores devDependencies. Since we bundle all of our code with webpack, technically everything is a development dependency so one solution would be to move all dependencies to
devDependencies
. However, I think it's cleaner for us to just excludenode_modules
and to keep thedependencies
section referencing only the dependencies that we actually use in the app.Additionally, this adjusts how we package the
about
window code and resolves an issue where it was not correctly displaying the logo when runningyarn start
Motivation and Context:
Fix build issues.
How Has This Been Tested?
yarn dev
,yarn start
,yarn package
Types of changes:
Build gfixes
Checklist: