Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

build(electron): exclude node modules from production app #1939

Merged
merged 1 commit into from
Apr 2, 2019

Conversation

mrfelton
Copy link
Member

@mrfelton mrfelton commented Apr 2, 2019

Description:

Since flattening the repo in #1895 the linux builds have been broken. On investigation I've discovered that it's attempting to package a bunch of node_modules that it should not be.

By default, electron-builder packages app production dependencies and ignores devDependencies. Since we bundle all of our code with webpack, technically everything is a development dependency so one solution would be to move all dependencies to devDependencies. However, I think it's cleaner for us to just exclude node_modules and to keep the dependencies section referencing only the dependencies that we actually use in the app.

Additionally, this adjusts how we package the about window code and resolves an issue where it was not correctly displaying the logo when running yarn start

Motivation and Context:

Fix build issues.

How Has This Been Tested?

yarn dev, yarn start, yarn package

Types of changes:

Build gfixes

Checklist:

  • My code follows the code style of this project.
  • I have reviewed and updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes where needed.
  • All new and existing tests passed.
  • My commits have been squashed into a concise set of changes.

@mrfelton mrfelton added the type: chore Misc task label Apr 2, 2019
@mrfelton mrfelton added this to the v0.4.1-beta milestone Apr 2, 2019
@mrfelton mrfelton self-assigned this Apr 2, 2019
@mrfelton mrfelton requested a review from korhaliv April 2, 2019 09:53
@coveralls
Copy link

Coverage Status

Coverage remained the same at 19.453% when pulling 2a05029 on mrfelton:fix/packaging into 4741fb4 on LN-Zap:master.

@coveralls
Copy link

coveralls commented Apr 2, 2019

Coverage Status

Coverage remained the same at 19.453% when pulling 392aa37 on mrfelton:fix/packaging into 8dea45c on LN-Zap:master.

Copy link
Member

@korhaliv korhaliv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested ACK 2a05029

@mrfelton mrfelton merged commit ad33faa into LN-Zap:master Apr 2, 2019
@mrfelton mrfelton deleted the fix/packaging branch April 2, 2019 19:29
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
type: chore Misc task
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants