Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

fix(ui): make sure connection string visibility toggle is respected #2787

Closed
wants to merge 1 commit into from

Conversation

bolatovumar
Copy link
Contributor

Looks like there was a change during a recent refactor where the {...otherProps} piece was moved from the bottom to the top which broke the connection string component. This PR fixes it but I can guarantee it doesn't break something else if that change of moving {...otherProps} was intentional and if some other components are relying on this.

Motivation and Context:

fix #2785

How Has This Been Tested?

Manually

Checklist:

  • My code follows the code style of this project.
  • I have reviewed and updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes where needed.
  • All new and existing tests passed.
  • My commits have been squashed into a concise set of changes.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 23.532% when pulling 3fda69a on bolatovumar:fix-2785 into 7516b3f on LN-Zap:next.

@bolatovumar
Copy link
Contributor Author

Closing this as something weird is going on.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants