Ethernet support #1
Conversation
| The exit code should be 0. | ||
|
|
||
| ## Repository Layout | ||
| * include/Telemetry - Contains Telemetry.h file detailing communication conventions for the Arduino. Must change paramater to switch communication modes between Serial, Ethernet TCP, Ethernet UDP, etc. |
There was a problem hiding this comment.
Typo: paramater->parameter
| ```> wine python -c 'import matplotlib; import serial; import typing; import pywintypes'``` | ||
| The exit code should be 0. | ||
|
|
||
| ## Repository Layout |
| #include <avr/pgmspace.h> | ||
|
|
||
| // Set the protocall here: Serial, Ethernet | ||
| #define Protocall Ethernet_TCP |
There was a problem hiding this comment.
Spelling error: protocall -> protocol
Also, this helper stuff generally looks pretty reasonable, although I would request that macros/defines are named as ALL_CAPS, just as a style thing.
| /* inline Print &operator <<(Print &obj, _EndLineCode arg) */ | ||
| /* { obj.println(); return obj; } */ | ||
|
|
||
| #define BEGIN_SEND { \ |
There was a problem hiding this comment.
For the actual protocol, I've been considering making a significant change to this for Ethernet. The only reason for the weird thing with @@@@@ and &&&&& was a workaround for the issue that we only had one method of output, and I didn't want debugging Serial.print(...) statements to break telemetry.
Since Ethernet doesn't need to include this same sort of debugging flexibility, we could do away with the opening and closing symbols, slightly improving performance. We can change actual status/error messages, currently sent via Serial, to send as just another data field instead.
IDK, just a thought. But this is something we don't need to change right now, I can mess with it later.
@JWCS I'm opening a pull request now so I can post comments - this doesn't need to get merged right away.