Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add color-dependent tpcf test #100

Merged
merged 5 commits into from
Apr 11, 2018
Merged

add color-dependent tpcf test #100

merged 5 commits into from
Apr 11, 2018

Conversation

yymao
Copy link
Member

@yymao yymao commented Apr 8, 2018

This PR adds the color-dependent tpcf test (as requested in #73). A run of this test on the protoDC2 catalog can be found at:
https://portal.nersc.gov/project/lsst/descqa/v2/?run=2018-04-07_24&test=tpcf_Zehavi2011_color

While the code works, there seems to be some issues/bugs with the correlation calculation. However, I still wasn't able to identify the issue. So I'm still submitting this PR and hopefully people can take a look.

(cc @evevkovacs @vvinuv @aphearin)

@yymao
Copy link
Member Author

yymao commented Apr 9, 2018

@aphearin @evevkovacs I think I understand why the correlation functions look strange in some cases -- I don't think we have enough galaxies for some of these samples given the redshift cuts we applied! In particular, I now print out the galaxy count in each sample and you can see that these numbers are not large enough to produce robust measurement. If we want to test low-z clustering maybe we need to do it on snapshots?

@aphearin
Copy link

aphearin commented Apr 9, 2018

What is the redshift range @yymao - these numbers are awfully low?

Also, Mr_-23_-22_blue should probably be eliminated - the Universe does produce many such galaxies.

@yymao
Copy link
Member Author

yymao commented Apr 9, 2018

We are using the redshift ranges as in Zehavi 2011. However, due to the small sky area of protoDC2, there's very few galaxies in those low redshift bins (volume too small). So I think we'll have to test this on snapshot catalogs (unless there's other smart suggestions).

@evevkovacs
Copy link
Contributor

@yymao @aphearin But I recall the test results also didn't look good for Buzzard and that catalogue should not suffer from lack of galaxies. We should run Buzzard through all of the latest versions of these correlation-function tests to see where we stand.

@yymao
Copy link
Member Author

yymao commented Apr 9, 2018

@evevkovacs I don't think we've run tpcf on the full Buzzard --- we might have to submit a job for that.

@evevkovacs
Copy link
Contributor

I think it would be worth doing. Run all of the available tpcf tests

@yymao yymao merged commit b1f5850 into master Apr 11, 2018
@yymao yymao deleted the color-dep-clustering branch April 11, 2018 19:49
@yymao yymao mentioned this pull request Jun 14, 2018
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants