-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add color-dependent tpcf test #100
Conversation
@aphearin @evevkovacs I think I understand why the correlation functions look strange in some cases -- I don't think we have enough galaxies for some of these samples given the redshift cuts we applied! In particular, I now print out the galaxy count in each sample and you can see that these numbers are not large enough to produce robust measurement. If we want to test low-z clustering maybe we need to do it on snapshots? |
What is the redshift range @yymao - these numbers are awfully low? Also, Mr_-23_-22_blue should probably be eliminated - the Universe does produce many such galaxies. |
We are using the redshift ranges as in Zehavi 2011. However, due to the small sky area of protoDC2, there's very few galaxies in those low redshift bins (volume too small). So I think we'll have to test this on snapshot catalogs (unless there's other smart suggestions). |
@evevkovacs I don't think we've run tpcf on the full Buzzard --- we might have to submit a job for that. |
I think it would be worth doing. Run all of the available tpcf tests |
This PR adds the color-dependent tpcf test (as requested in #73). A run of this test on the protoDC2 catalog can be found at:
https://portal.nersc.gov/project/lsst/descqa/v2/?run=2018-04-07_24&test=tpcf_Zehavi2011_color
While the code works, there seems to be some issues/bugs with the correlation calculation. However, I still wasn't able to identify the issue. So I'm still submitting this PR and hopefully people can take a look.
(cc @evevkovacs @vvinuv @aphearin)