Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update color cut in CLF test #122

Merged
merged 1 commit into from
Jun 29, 2018
Merged

Update color cut in CLF test #122

merged 1 commit into from
Jun 29, 2018

Conversation

yymao
Copy link
Member

@yymao yymao commented Jun 26, 2018

This PR fixes #121. Here's an example run: https://portal.nersc.gov/project/lsst/descqa/v2/?run=2018-06-26_9&test=CLF_r

However, @evevkovacs, I wasn't able to test this on the new UM catalog. Can you point me a working GCRCatalogs that has the UM catalog in the configs? Thanks!

@yymao yymao requested a review from chto June 26, 2018 21:00
@evevkovacs
Copy link
Contributor

@yymao Yes, please use -p /global/u1/k/kovacs/gcr-catalogs_um The catalog name is um_hpx_v0.0 and now covers a few hundred sq. deg. If you need something smaller (eg 1 healpix) I just made a config file for um_hpx_test_368, but haven't tested it yet. Let me know if you get errors.

@yymao
Copy link
Member Author

yymao commented Jun 27, 2018

@evevkovacs thanks, that works. Here is the DESCQA run of this PR on the UM catalog: https://portal.nersc.gov/project/lsst/descqa/v2/?run=2018-06-26_15&test=CLF_r

@EiffL EiffL self-requested a review June 29, 2018 19:24
@EiffL EiffL self-assigned this Jun 29, 2018
Copy link
Member

@EiffL EiffL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, looks good to me

@yymao yymao merged commit 9627853 into master Jun 29, 2018
@yymao yymao deleted the issue/121/clf-color-cut branch June 29, 2018 19:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

color cut in CLF test should work on catalogs that have redshift blocks
3 participants