Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move twopoint theory #462

Merged
merged 28 commits into from
Oct 18, 2024
Merged

Move twopoint theory #462

merged 28 commits into from
Oct 18, 2024

Conversation

marcpaterno
Copy link
Collaborator

Description

Please include a summary of the change(s). Include which issue is fixed, if this is a bug fix.
Please also include relevant motivation and context. List any new dependencies that are required for this
change.

Fixes # (issue)
Discussion: # (link)

Type of change

Please delete the bullet items below that do not apply to this pull request.

  • Refactoring
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

This refactoring contains possible breaking changes because it changes the internal data of TwoPoint, and those internal data are not hidden from users.

Checklist:

The following checklist will make sure that you are following the code style and
guidelines of the project as described in the
contributing page.

  • I have run bash pre-commit-check and fixed any issues
  • I have added tests that prove my fix is effective or that my feature works
  • I have made corresponding changes to the documentation
  • I have 100% test coverage for my changes (please check this after the CI system has verified the coverage)

Copy link

codecov bot commented Oct 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.7%. Comparing base (95db9c3) to head (c7fc43c).
Report is 12 commits behind head on master.

Additional details and impacted files
@@          Coverage Diff           @@
##           master    #462   +/-   ##
======================================
  Coverage    98.6%   98.7%           
======================================
  Files          53      54    +1     
  Lines        4035    4066   +31     
======================================
+ Hits         3981    4015   +34     
+ Misses         54      51    -3     
Files with missing lines Coverage Δ
firecrown/likelihood/number_counts.py 91.1% <100.0%> (ø)
firecrown/likelihood/source.py 100.0% <ø> (ø)
firecrown/likelihood/statistic.py 91.1% <ø> (ø)
firecrown/likelihood/two_point.py 99.5% <100.0%> (+0.9%) ⬆️
firecrown/models/two_point.py 100.0% <100.0%> (ø)
firecrown/parameters.py 99.3% <100.0%> (+<0.1%) ⬆️
firecrown/updatable.py 100.0% <100.0%> (ø)

@marcpaterno marcpaterno marked this pull request as ready for review October 18, 2024 21:05
@marcpaterno marcpaterno requested a review from vitenti October 18, 2024 21:05
@marcpaterno marcpaterno merged commit 96b38ba into master Oct 18, 2024
9 checks passed
@marcpaterno marcpaterno deleted the move_twopoint_theory branch October 18, 2024 21:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants