Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add config for new extragalactic truth catalog #253

Merged
merged 6 commits into from
Jan 25, 2019

Conversation

danielsf
Copy link
Contributor

This PR adds the new truth catalog for static extra galactic sources. It includes columns

u - observed u-band magnitude
du_mw - extinction in u-band due to Milky Way dust
du_internal - extinction in u-band due to internal dust
etc.

It does not include truth information for stars. Let me know if that is a problem.

@danielsf danielsf requested a review from yymao January 24, 2019 16:42
@yymao
Copy link
Member

yymao commented Jan 24, 2019

@danielsf does it only has u band, or that was just an example?

Not having stars may be an issue with matching, but should be OK for folks that are looking at galaxies only (e.g. WL, CL). I wonder what @rmandelb thinks.

@danielsf
Copy link
Contributor Author

It has all the bands. I did not want to type them out

@danielsf
Copy link
Contributor Author

Should we get Eli's input. The impression I got from yesterday's phonecon was that his needs were driving the push for this catalog.

@yymao
Copy link
Member

yymao commented Jan 24, 2019

Sure. My guess is that for @erykoff's specific need, not having stars is not an issue?

@erykoff
Copy link
Contributor

erykoff commented Jan 24, 2019

I don't need stars for these comparisons. What's driving the question is that I want to be able to distinguish differences in red cluster galaxies between the extragalactic catalog and the object catalog that are due to the way the galaxies were simulated (in the truth catalog) and issues with the processing. I'm sure this won't be the only use case.

@yymao
Copy link
Member

yymao commented Jan 24, 2019

Minor question: for the truth catalog, galaxies are always static objects, right? If so we can just name this dc2_truth_run1.2_galaxies.yaml (which is what we used for run1.1)?

@danielsf
Copy link
Contributor Author

Some galaxies contain AGN, which vary. These galaxies are going to appear as variable sources in the catalogs of detected objects.

@katrinheitmann
Copy link

katrinheitmann commented Jan 24, 2019 via email

@yymao
Copy link
Member

yymao commented Jan 24, 2019

@danielsf ah, right. So are galaxies that contain AGNs also excluded from this truth catalog?

@danielsf
Copy link
Contributor Author

@yymao This catalog includes the static magnitudes of the galaxies (i.e. the magnitudes of the bulge and disk). All galaxies have an agn column that is 1 if the galaxy contains an AGN and 0 otherwise.

@yymao
Copy link
Member

yymao commented Jan 24, 2019

@katrinheitmann I think for Run 2.x the truth catalog solution would be completely different, as we discussed in the CS telecon yesterday. But in the meantime we still need a truth catalog for people who want to analyze Run 1.2i, so I think an updated 1.2 truth catalog is still needed. This PR already provides a solution for the galaxies; the remaining question is whether we need the same for stars.

@yymao
Copy link
Member

yymao commented Jan 24, 2019

I think this PR is ready to be merged. I'll wait till the end of the day in case there's further comments on this.

There's still a separate question on whether we need stars with the extinction to be included in the truth catalog.

@yymao yymao merged commit d5a4d0c into master Jan 25, 2019
@yymao yymao deleted the u/danielsf/1p2/truth/extinction branch February 5, 2019 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants