photo-z calibration catalog reader #275
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yymao
added
reader
|
…catalogs into u/yymao/photo-calib-reader
|
Functional checks for this PR are all completed. |
|
This is now ready for review. @morriscb, I've assigned you as a reviewer but maybe you would like to suggest someone else? |
|
Seems to be against the idea of a review for one of the authors to review. Perhaps @sschmidt23 another person from PZ could do it. |
sschmidt23
approved these changes
Apr 9, 2019
There was a problem hiding this comment.
This looks good to me, I tested the catalog and it worked just fine, the only slight gotcha was me checking list_all_quantities and being confused that there were no entries for a second before I realized to check list_all_native_quantities to find the boolean flags.
sschmidt23
previously approved these changes
Apr 9, 2019
|
Thanks @sschmidt23, I've addressed your comment. @morriscb I'm merging this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
photo-z calibration catalog reader provided by @morriscb