Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make native_filters backward compatible for truth catalog #309

Merged
merged 1 commit into from
May 30, 2019
Merged

make native_filters backward compatible for truth catalog #309

merged 1 commit into from
May 30, 2019

Conversation

yymao
Copy link
Member

@yymao yymao commented May 30, 2019

Truth summary catalogs now use hdf5, not sql, and hence native_filters would no longer works and people should use filters instead.

This PR makes native_filters backward compatible for truth summary catalog, but prints out a warning to notify the users.

@yymao yymao requested a review from danielsf May 30, 2019 16:46
danielsf
danielsf approved these changes May 30, 2019
View reviewed changes
Copy link
Contributor

@danielsf danielsf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

Thanks for fixing this

@yymao yymao merged commit 1f5e66f into master May 30, 2019
@yymao yymao deleted the u/yymao/truth-native-filters-warning branch May 30, 2019 19:24
@yymao yymao mentioned this pull request May 30, 2019
Merged
6 tasks
@yymao yymao added this to the v0.11.0 milestone May 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danielsf danielsf danielsf approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v0.11.0
Development

Successfully merging this pull request may close these issues.
2 participants
@yymao @danielsf