update default catalog list #325
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yymao
added
register
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is an option that can be specified in the catalog config to determine whether the catalog in consideration will show up when an user runs
GCRCatalogs.get_available_catalog(), or only show up when the user runsGCRCatalogs.get_available_catalog(include_default_only=False).The reason for this difference is that the number of catalogs is large, and most catalogs are not interesting for end users.
This option was named
included_by_default, but it is not clear to most people what this option means, so it was later renamed toinclude_in_default_catalog_list. However, it seems that people have not been using the new name. This PR makes this change once and for all. This PR also selects fewer "default catalogs".