Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove dependence of obs_lsstSim for geometry information. #156

Closed
cwwalter opened this issue Sep 6, 2018 · 9 comments
Closed

Remove dependence of obs_lsstSim for geometry information. #156

cwwalter opened this issue Sep 6, 2018 · 9 comments
Assignees
Labels
Milestone

Comments

@cwwalter
Copy link
Member

cwwalter commented Sep 6, 2018

This is different than #121 which addresses using the camera objects to get sensor information for writing the amp files. This work primarily involves how sims_galSimInterface gets various geometry information.

@cwwalter
Copy link
Member Author

cwwalter commented Nov 19, 2018

@danielsf and @jchiang87 I lost track of the status of this one. There were some failing tests etc which stopped previous work last I heard. Has anything changed?

@jchiang87
Copy link
Collaborator

As far as I know, no new work had been done on this. It's still an open issue.

@cwwalter
Copy link
Member Author

OK. Can we live with this for DC2? Or should we target it for changing?

@jchiang87
Copy link
Collaborator

I think we should just live with it for DC2. I doubt Scott or I have time to deal with it.

@cwwalter
Copy link
Member Author

OK removing not adding a DC2 label to this (but not pushing all the way to DC3).

@cwwalter
Copy link
Member Author

Note: sims_galSimInterface is also depending on obs_lsstSim through its use of an LsstObservatory() object used to return telescope position with code like:

        observatory = LsstObservatory()
         self.fitsHeader.set('OBS-LONG', observatory.getLongitude().asDegrees())
         self.fitsHeader.set('OBS-LAT', observatory.getLongitude().asDegrees())
         self.fitsHeader.set('OBS-ELEV', observatory.getElevation())
         obs_location = observatory.getLocation()
         self.fitsHeader.set('OBSGEO-X', obs_location.geocentric[0].value)
         self.fitsHeader.set('OBSGEO-Y', obs_location.geocentric[1].value)
         self.fitsHeader.set('OBSGEO-Z', obs_location.geocentric[2].value)

Are there other ways to get this information?

@jchiang87
Copy link
Collaborator

jchiang87 commented Nov 27, 2018

@cwwalter
Copy link
Member Author

Per @danielsf this work is currently planned on a June 2019 timescale.

@cwwalter cwwalter added this to the imSim 2.0 milestone Aug 17, 2022
@cwwalter
Copy link
Member Author

We now rely on the science pipelines obs_lsst for camera information.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants