Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

set gains, read noise and crosstalk for imsim #41

Merged
merged 1 commit into from
Dec 3, 2018

Conversation

jchiang87
Copy link
Contributor

No description provided.

@cwwalter
Copy link
Member

I'm not very familiar with this package yet. Is the reason there are only additions to files in this PRM that the imSim info used to be somewhere else?

@cwwalter
Copy link
Member

Another quick question: I see there is raft offset info in raft.yaml.

So, I'm curious: in LSSTDESC/imSim#156 we discuss how we are still getting geometry info for sims_galSimInterface from obs_lsstSim. Is this info duplicative / in sync with that info? I'm just wondering how it might interface with the sensor positions there which eventually come from the segmentation.txt file if it is the same info. Is it nothing to worry about?

@jchiang87
Copy link
Contributor Author

When imSim was using the LsstCamMapper, the gain and read noise info was coming from the files in policy/lsstCam. I added the corresponding files to policy/imsim with the gain and read noise set, and added ccdData.yaml for the crosstalk values. I included a copy of rafts.yaml since it was also in policy/phosim, but maybe just having policy/rafts.yaml is sufficient. In any case, I don't think anything is being duplicated vis-a-vis obs_lsstSim, and segmentation.txt is irrelevant at this point.

@cwwalter
Copy link
Member

Thanks.

Structure and values looks good to me, but I haven't really looked at this package before. Probably good to get a review from a real expert.

Thinking ahead: If we have comCam or different FP configurations we would have different directories with other names (like imsim-comcam)?

Happy Thanksgiving all!

@heather999 heather999 force-pushed the u/jchiang/add_imsim_readout_params branch from f97645a to d4b39c0 Compare December 3, 2018 14:51
@heather999
Copy link
Collaborator

After consulting with Robert, Jim did some additional checking. This is good to go, now rebased, and merging to master.

@heather999 heather999 merged commit e89361f into master Dec 3, 2018
@RobertLuptonTheGood
Copy link
Member

Re "Thinking ahead: If we have comCam or different FP configurations we would have different directories with other names (like imsim-comcam)?"
Providing you only have one camera configuration that is valid at any one time (so one imsim, one phosim, one comCam, one lsstCam, ...) we plan to handle this via versioning the information like any other calibration product (e.g. a flat field). But that requires butler Gen3

@jchiang87 jchiang87 deleted the u/jchiang/add_imsim_readout_params branch January 7, 2019 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants