Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cmake: add opencv_videoio, new library in openCV 3.X.X #126

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

krisgry
Copy link
Contributor

@krisgry krisgry commented Apr 27, 2018

Should be seen in the context of LSTS/glued#36

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@zepinto zepinto requested a review from pmfg July 12, 2018 10:19
@zepinto
Copy link
Member

zepinto commented Jul 12, 2018

Will leave it to @pmfg to decide on this (he has been working with OpenCV on our side).

@pmfg
Copy link
Contributor

pmfg commented Jul 16, 2018

It will require a check for the opencv version used, since version 2.4.x does not have the opencv_videoio library (compatibility with the old opencv version - LSTS/glued#36)

@krisgry
Copy link
Contributor Author

krisgry commented Jul 26, 2018

To clarify: Will the following changes suffice?

  • add a new rule to glued, called opencv3, that is identical to the opencv rule except that it is updated to version 3.X.X (and a different checksum ofc). Or is there a smarter way to keep track of different versions?
  • within the if(HAVE_LIB_OPENCV) in cmake/Libraries/OpenCV.cmake; run something like CHECK_LIBRARY_EXISTS(opencv_videoio open "" HAVE_LIB_OPENCV3). If HAVE_LIB_OPENCV3 is true, we'll add opencv_videoio and do set(DUNE_SYS_HAS_OPENCV3 1 CACHE INTERNAL "OpenCV library") videoio ref
  • Tasks that require OpenCV 3.X.X will need to check DUNE_SYS_HAR_OPENCV3, while older tasks (requiring 2.X.X) do not have to change their cmake.

Please be critical, as I'm no cmake expert!

@pmfg
Copy link
Contributor

pmfg commented Aug 7, 2018

For me it seems like a good solution to the incompatibility of opencv versions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants