Release the lock before notifying the waiting thread in destructor.

This is consistent with the other uses of notify_one(), otherwise the waiting thread would block immediately and need to wait for the lock to be released.
LTLA · Jul 15, 2024 · ad206e3 · ad206e3
1 parent f301081
commit ad206e3
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/CMakeLists.txt b/CMakeLists.txt
@@ -1,7 +1,7 @@
 cmake_minimum_required(VERSION 3.24)
 
 project(byteme
-    VERSION 1.2.1
+    VERSION 1.2.2
     DESCRIPTION "No-frills byte streaming from file"
     LANGUAGES CXX)
 

diff --git a/include/byteme/PerByte.hpp b/include/byteme/PerByte.hpp
@@ -253,9 +253,10 @@ class PerByteParallel {
      */
     ~PerByteParallel() {
         if (!my_finished) {
-            std::lock_guard lck(my_mut);
+            std::unique_lock lck(my_mut);
             my_finished = true;
             my_ready_input = true;
+            lck.unlock(); // releasing the lock so that the notified thread doesn't immediately block.
             my_cv.notify_one();
         }
         my_thread.join();