add automatic promethues metrics for roundtrip db query times #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change adds a prometheus Histogram to each database connection. The promauto.Histogram will automatically register with the default prometheus client, if one exists. This change also adds a set of methods to the the coresql.DB that override the Exec/Query methods of the underlying sql.DB. These methods record, to the prometheus histogram, the duration of the Exec/Query call to the underlying sql.DB. If the application uses the core metrics server from LUSHDigital/core/workers/metricsrv, the database histogram will be available via that metrics server's endpoint without any further changes to your code.
adamlounds
reviewed
Jan 10, 2020
| } | ||
|
|
||
| // Check will attempt to ping the database to see if the connection is still alive. |
There was a problem hiding this comment.
Looks like you accidentally removed comment/docs for Check function, which broke the build.
There was a problem hiding this comment.
If you fix this, I can get this merged. This is really useful.
zeevallin
suggested changes
Mar 19, 2020
| } | ||
|
|
||
| // Check will attempt to ping the database to see if the connection is still alive. |
There was a problem hiding this comment.
If you fix this, I can get this merged. This is really useful.
|
Sorry @zdjones I completely missed this MR. My bad. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds a prometheus Histogram to each database connection. The
promauto.Histogram will automatically register with the default
prometheus client, if one exists. This change also adds a set of methods
to the the coresql.DB that override the Exec/Query methods of the
underlying sql.DB. These methods record, to the prometheus histogram, the
duration of the Exec/Query call to the underlying sql.DB.
If the application uses the core metrics server from
LUSHDigital/core/workers/metricsrv, the database histogram will be available
via that metrics server's endpoint without any further changes to your
code.