Fb dataset update rewrite #6552
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
WARNING: This PR appears to have the default title generated by GitHub. Please use something more descriptive. |
|
WARNING: This PR appears to have the default title generated by GitHub. Please use something more descriptive. |
study/src/org/labkey/study/model/DatasetDataIteratorBuilder.java
Outdated
Show resolved
Hide resolved
study/src/org/labkey/study/model/DatasetDataIteratorBuilder.java
Outdated
Show resolved
Hide resolved
labkey-chrisj
approved these changes
May 12, 2025
XingY
reviewed
May 12, 2025
labkey-matthewb
approved these changes
May 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale
Dataset
updateRowshad previously been implemented as a single row delete followed by an insert row. This PR attempts to rewrite this code to look like more typicalQueryUpdateService.updateRowimplementations.This work was focused on a few main areas and tasks:
DatasetDataIteratorBuilderso they could be used outside of aDataIteratorcontext. These helpers were responsible for : LSID, subject ID, sequence number, and participant sequence number generation.DatasetDataIteratorBuilderDatasetUpdateService.updateRowto use the new helpers as well asTable.updateto update the row.