Fb dataset update rewrite #6552
Conversation
|
WARNING: This PR appears to have the default title generated by GitHub. Please use something more descriptive. |
|
WARNING: This PR appears to have the default title generated by GitHub. Please use something more descriptive. |
|
@mbellew I'm going to need your opinion on the test failure I'm seeing in It also looks like other data types don't support this on update either. Do you think the old behavior is still required, should there be code in |
| return null; | ||
|
|
||
| Object o = it.get(i); | ||
| if (null == o) |
There was a problem hiding this comment.
JdbcType.DOUBLE.convert(o)
| return null; | ||
|
|
||
| Object o = it.get(i); | ||
| return null == o ? "" : o.toString(); |
There was a problem hiding this comment.
Objects.toString(o,"")
| try (DbScope.Transaction transaction = StudyService.get().getDatasetSchema().getScope().ensureTransaction()) | ||
| { | ||
| String lsid = keyFromMap(oldRow); | ||
| checkDuplicateUpdate(lsid);// Make sure we've found the original participant before doing the update |
There was a problem hiding this comment.
The comment is for the next line, not checkDuplicateUpdate, a merge error I believe.
Rationale
Dataset
updateRowshad previously been implemented as a single row delete followed by an insert row. This PR attempts to rewrite this code to look like more typicalQueryUpdateService.updateRowimplementations.This work was focused on a few main areas and tasks:
DatasetDataIteratorBuilderso they could be used outside of aDataIteratorcontext. These helpers were responsible for : LSID, subject ID, sequence number, and participant sequence number generation.DatasetDataIteratorBuilderDatasetUpdateService.updateRowto use the new helpers as well asTable.updateto update the row.