Skip to content

Issue 53253: forego indexing data class in a container being deleted #6821

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 6, 2025
Merged

Issue 53253: forego indexing data class in a container being deleted #6821

merged 1 commit into from
Jul 6, 2025

Conversation

labkey-nicka
Copy link
Contributor

Rationale

This addresses Issue 53253 by checking that the dataClass instance that is about to be indexed has a container.

Changes

  • Check for data class container prior to indexing
  • Annotate ExpDataClassImpl.getTinfo() as @NotNull and update usages
  • Add assertion check for container in ExpDataClassImpl.getDomain()

@labkey-nicka labkey-nicka self-assigned this Jul 4, 2025
labkey-susanh
labkey-susanh approved these changes Jul 4, 2025
View reviewed changes
Copy link
Contributor

@labkey-susanh labkey-susanh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@labkey-nicka labkey-nicka merged commit 4935d72 into develop Jul 6, 2025
15 checks passed
@labkey-nicka labkey-nicka deleted the fb_npe_53253 branch July 6, 2025 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@labkey-susanh labkey-susanh labkey-susanh approved these changes

Assignees

@labkey-nicka labkey-nicka

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@labkey-nicka @labkey-susanh