Skip to content

[PLT-1463] Removed ND deserialize from some unit test part 1 #1804

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 13 commits into from
Sep 16, 2024
Merged

[PLT-1463] Removed ND deserialize from some unit test part 1 #1804

merged 13 commits into from
Sep 16, 2024

Conversation

@Gabefire
Copy link
Collaborator

@Gabefire Gabefire commented Sep 11, 2024 •
edited
Loading

Description

  • Removes/refactors around half of the deserialized tests with corresponding assets

@Gabefire Gabefire requested a review from a team as a code owner September 11, 2024 16:14
@Gabefire Gabefire force-pushed the gu/remove_deserialize_from_test branch from bed0a54 to 5e168f7 Compare September 11, 2024 16:36
@Gabefire Gabefire marked this pull request as draft September 11, 2024 16:41
adrian-chang
adrian-chang previously approved these changes Sep 12, 2024
View reviewed changes
@Gabefire Gabefire marked this pull request as ready for review September 13, 2024 01:44
@Gabefire Gabefire changed the title [PLT-1463] Removed ND deserialize from some unit test [PLT-1463] Removed ND deserialize from some unit test part 1 Sep 13, 2024
vbrodsky
vbrodsky approved these changes Sep 13, 2024
View reviewed changes
Copy link
Contributor

@vbrodsky vbrodsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved but let's merge on Monday to our new v5 branch

@Gabefire Gabefire changed the base branch from develop to v6 September 16, 2024 18:06
@Gabefire Gabefire merged commit 37c038e into v6 Sep 16, 2024
17 of 25 checks passed
@Gabefire Gabefire deleted the gu/remove_deserialize_from_test branch September 16, 2024 18:06
vbrodsky pushed a commit that referenced this pull request Sep 17, 2024
@Gabefire
[PLT-1463] Removed ND deserialize from some unit test part 1 (#1804)
b5ec4e3
vbrodsky pushed a commit that referenced this pull request Sep 17, 2024
@Gabefire
[PLT-1463] Removed ND deserialize from some unit test part 1 (#1804)
22796f8
vbrodsky pushed a commit that referenced this pull request Sep 18, 2024
@Gabefire
[PLT-1463] Removed ND deserialize from some unit test part 1 (#1804)
a47348f
Gabefire added a commit that referenced this pull request Sep 18, 2024
@Gabefire
[PLT-1463] Removed ND deserialize from some unit test part 1 (#1804)
30819db
vbrodsky pushed a commit that referenced this pull request Oct 11, 2024
@Gabefire
[PLT-1463] Removed ND deserialize from some unit test part 1 (#1804)
c1d39f7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@adrian-chang adrian-chang Awaiting requested review from adrian-chang

1 more reviewer

@vbrodsky vbrodsky vbrodsky approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Gabefire @adrian-chang @vbrodsky