Skip to content

[PLT-1797] Vb/member upload plt 1797 #1924

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Dec 6, 2024
Merged

Conversation

vbrodsky
Copy link
Contributor

@vbrodsky vbrodsky commented Dec 6, 2024

Description

Story: https://labelbox.atlassian.net/browse/PLT-1797

This adds the ability to upload member emails to a group using the same api UI uses to Import Members

Implementation notes:

  • I have duplicated code for multipart file upload but created this story to abstract this better in the near future
  • Unfortunately there is no way to have an sdk integration test atm due to lots of preconditions that can not be setup cvia sdk calls
    • In short term I will ask QA whether they can add a test
    • Will discuss possible solutions with Adrian

Fixes # (issue)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Document change (fix typo or modifying any markdown files, code comments or anything in the examples folder only)

All Submissions

  • Have you followed the guidelines in our Contributing document?
  • Have you provided a description?
  • Are your changes properly formatted?

New Feature Submissions

  • Does your submission pass tests?
  • Have you added thorough tests for your new feature?
  • Have you commented your code, particularly in hard-to-understand areas?
  • Have you added a Docstring?

Changes to Core Features

  • Have you written new tests for your core changes, as applicable?
  • Have you successfully run tests with your changes locally?
  • Have you updated any code comments, as applicable?

@vbrodsky vbrodsky merged commit 78a7e3d into develop Dec 6, 2024
15 of 23 checks passed
@vbrodsky vbrodsky deleted the VB/member-upload_PLT-1797 branch December 6, 2024 19:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants