Skip to content

[PLT-2228] Move to task queue task id to be optional with default as None for better type support #1929

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Dec 17, 2024
Merged

[PLT-2228] Move to task queue task id to be optional with default as None for better type support #1929

merged 4 commits into from
Dec 17, 2024

Conversation

Gabefire
Copy link
Collaborator

@Gabefire Gabefire commented Dec 16, 2024 •
edited
Loading

Description

  • Switched type of task_queu_id to be optional with default of None which is a valid value.

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

All Submissions

  • Have you followed the guidelines in our Contributing document?
  • Have you provided a description?
  • Are your changes properly formatted?

@Gabefire Gabefire requested a review from a team as a code owner December 16, 2024 16:53
vbrodsky
vbrodsky previously approved these changes Dec 16, 2024
View reviewed changes
@Gabefire Gabefire merged commit 1869d88 into develop Dec 17, 2024
17 of 23 checks passed
@Gabefire Gabefire deleted the gu/adjust_optional branch December 17, 2024 22:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@vbrodsky vbrodsky vbrodsky approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Gabefire @vbrodsky