Skip to content

[PTDT-3037] Add AUDIO AttachmentType #1956

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 13, 2025
Merged

[PTDT-3037] Add AUDIO AttachmentType #1956

merged 1 commit into from
Mar 13, 2025

Conversation

kvilon
Copy link
Member

@kvilon kvilon commented Mar 6, 2025 •
edited
Loading

Description

Please include a summary of the changes and the related issue. Please also include relevant motivation and context.

Related PR:
https://github.com/Labelbox/intelligence/pull/24902

Fixes # (issue)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Document change (fix typo or modifying any markdown files, code comments or anything in the examples folder only)

All Submissions

  • Have you followed the guidelines in our Contributing document?
  • Have you provided a description?
  • Are your changes properly formatted?

New Feature Submissions

  • Does your submission pass tests?
  • Have you added thorough tests for your new feature?
  • Have you commented your code, particularly in hard-to-understand areas?
  • Have you added a Docstring?

Changes to Core Features

  • Have you written new tests for your core changes, as applicable?
  • Have you successfully run tests with your changes locally?
  • Have you updated any code comments, as applicable?

@kvilon kvilon requested a review from a team as a code owner March 6, 2025 15:05
@kvilon
Copy link
Member Author

kvilon commented Mar 7, 2025 •
edited
Loading

Tests actually pass:

image image

@kvilon kvilon merged commit 33c480f into develop Mar 13, 2025
20 of 26 checks passed
@kvilon kvilon deleted the stan/3037/import-audio-attachment branch March 13, 2025 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Gabefire Gabefire Gabefire approved these changes

@manastalukdar manastalukdar Awaiting requested review from manastalukdar manastalukdar is a code owner automatically assigned from Labelbox/engineers

@lgluszek lgluszek Awaiting requested review from lgluszek lgluszek is a code owner automatically assigned from Labelbox/engineers

@chunpong chunpong Awaiting requested review from chunpong chunpong is a code owner automatically assigned from Labelbox/engineers

@KeshavSahoo KeshavSahoo Awaiting requested review from KeshavSahoo KeshavSahoo is a code owner automatically assigned from Labelbox/engineers

@cyrusj89 cyrusj89 Awaiting requested review from cyrusj89 cyrusj89 is a code owner automatically assigned from Labelbox/engineers

@ramy1951 ramy1951 Awaiting requested review from ramy1951 ramy1951 is a code owner automatically assigned from Labelbox/engineers

@labelbox-engineering labelbox-engineering Awaiting requested review from labelbox-engineering labelbox-engineering is a code owner automatically assigned from Labelbox/engineers

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kvilon @Gabefire