Skip to content

Remove mypy from dependencies. #1966

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

Remove mypy from dependencies. #1966

wants to merge 2 commits into from

Conversation

dnoursi
Copy link

@dnoursi dnoursi commented Apr 9, 2025 •
edited
Loading

Description

It is inconvenient for us to upgrade our environment's labelbox version without upgrading our mypy version, because of this dependency. I think that it can be appropriate for mypy to be in dev-dependencies only. This change would help us to upgrade our labelbox sdk.

Type of change

Please delete options that are not relevant.

  • [x ] Bug fix (non-breaking change which fixes an issue)

All Submissions

  • [x ] Have you followed the guidelines in our Contributing document?
  • [x ] Have you provided a description?
  • [x ] Are your changes properly formatted?

New Feature Submissions

  • Does your submission pass tests?
  • Have you added thorough tests for your new feature?
  • Have you commented your code, particularly in hard-to-understand areas?
  • Have you added a Docstring?

Changes to Core Features

  • Have you written new tests for your core changes, as applicable?
  • Have you successfully run tests with your changes locally?
  • Have you updated any code comments, as applicable?

@dnoursi dnoursi requested a review from a team as a code owner April 9, 2025 11:43
paulnoirel
paulnoirel approved these changes Apr 15, 2025
View reviewed changes
Copy link
Contributor

@paulnoirel paulnoirel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paulnoirel paulnoirel paulnoirel approved these changes

@manastalukdar manastalukdar Awaiting requested review from manastalukdar manastalukdar was automatically assigned from Labelbox/engineers

@chunpong chunpong Awaiting requested review from chunpong chunpong was automatically assigned from Labelbox/engineers

@KeshavSahoo KeshavSahoo Awaiting requested review from KeshavSahoo KeshavSahoo was automatically assigned from Labelbox/engineers

@cyrusj89 cyrusj89 Awaiting requested review from cyrusj89 cyrusj89 was automatically assigned from Labelbox/engineers

@ramy1951 ramy1951 Awaiting requested review from ramy1951 ramy1951 was automatically assigned from Labelbox/engineers

@labelbox-engineering labelbox-engineering Awaiting requested review from labelbox-engineering labelbox-engineering was automatically assigned from Labelbox/engineers

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dnoursi @paulnoirel