Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Benchmarks #342

Merged
merged 5 commits into from
Jul 5, 2021
Merged

Benchmarks #342

merged 5 commits into from
Jul 5, 2021

Conversation

JustineBoulant
Copy link
Contributor

Add reference scenarios notebook to notebooks folder

@codecov-commenter
Copy link

codecov-commenter commented May 4, 2021 •
edited
Loading

Codecov Report

Merging #342 (a869701) into master (ecc3ea8) will not change coverage.
The diff coverage is n/a.

❗ Current head a869701 differs from pull request most recent head b7ec1ce. Consider uploading reports for the commit b7ec1ce to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##           master     #342   +/-   ##
=======================================
  Coverage   80.68%   80.68%           
=======================================
  Files          15       15           
  Lines        3045     3045           
=======================================
  Hits         2457     2457           
  Misses        588      588

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ecc3ea8...b7ec1ce. Read the comment docs.

@bowni
Copy link
Member

bowni commented May 11, 2021

Notes from workgroup meeting on 2021.05.11:

  • Some could be included in the nighlty tests

bowni
bowni requested changes May 11, 2021
View reviewed changes
Copy link
Member

@bowni bowni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems almost good - I only commented very minor details 😃

notebooks/reference_scenarios/benchmarks.ipynb Outdated Show resolved Hide resolved
notebooks/reference_scenarios/benchmarks.ipynb Outdated Show resolved Hide resolved
bowni
bowni approved these changes Jun 29, 2021
View reviewed changes
Copy link
Member

@bowni bowni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! Thank you @JustineBoulant 👍

@bowni
Copy link
Member

bowni commented Jul 1, 2021

@RomainGoussault @arthurPignet @jeromechambost @celinejacques could one of you also review/approve this PR please? 😎

arthurPignet
arthurPignet approved these changes Jul 3, 2021
View reviewed changes
Copy link
Collaborator

@arthurPignet arthurPignet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice !

@bowni bowni merged commit 4fb247a into master Jul 5, 2021
@bowni bowni deleted the benchmarks branch July 5, 2021 07:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arthurPignet arthurPignet arthurPignet approved these changes

@bowni bowni bowni approved these changes

@natct10 natct10 Awaiting requested review from natct10 natct10 is a code owner

@RomainGoussault RomainGoussault Awaiting requested review from RomainGoussault RomainGoussault is a code owner

@Thomas-Galtier Thomas-Galtier Awaiting requested review from Thomas-Galtier Thomas-Galtier is a code owner

Assignees

@kat-leen kat-leen

@JustineBoulant JustineBoulant

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@JustineBoulant @codecov-commenter @bowni @arthurPignet @kat-leen