Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plot data distribution #353

Merged
merged 11 commits into from
Sep 17, 2021
Merged

Plot data distribution #353

merged 11 commits into from
Sep 17, 2021

Conversation

kat-leen
Copy link
Contributor

New plot of the data/ground truth distribution based on the one made by @bowni for the reference scenarios.

Changes :

  • The figure was entirely rebuilt with seaborn.
  • We can visualize both the real ground truth distribution and the corrupted one if there is any corrupted partner.
  • We can now display the plot after the scenario creation.
  • The plots were added in the notebook of the reference scenarios.
  • The code is divided into two parts, one in the Scenario class and the other one (more independent) in utils. But is it really relevant? I'm not sure whether it can be reused for something else or not.
  • The documentation was updated.

@codecov-commenter
Copy link

codecov-commenter commented Jul 16, 2021

Codecov Report

Merging #353 (e9851c7) into master (eb20b80) will increase coverage by 0.38%.
The diff coverage is 96.42%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #353      +/-   ##
==========================================
+ Coverage   79.48%   79.86%   +0.38%     
==========================================
  Files          15       15              
  Lines        3158     3224      +66     
==========================================
+ Hits         2510     2575      +65     
- Misses        648      649       +1     
Impacted Files Coverage Δ
mplc/scenario.py 80.39% <96.00%> (+0.87%) ⬆️
mplc/utils.py 86.71% <96.36%> (+6.03%) ⬆️
mplc/experiment.py 83.33% <100.00%> (ø)
mplc/partner.py 93.61% <100.00%> (+0.21%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eb20b80...e9851c7. Read the comment docs.

@bowni bowni added the enhancement New feature or request label Aug 17, 2021
@bowni bowni added this to the Release v0.4 milestone Aug 17, 2021
@bowni bowni linked an issue Aug 17, 2021 that may be closed by this pull request
@bowni bowni requested a review from HeytemBou August 17, 2021 10:02
mplc/doc/documentation.md Outdated Show resolved Hide resolved
mplc/doc/documentation.md Outdated Show resolved Hide resolved
mplc/utils.py Show resolved Hide resolved
mplc/utils.py Show resolved Hide resolved
mplc/utils.py Show resolved Hide resolved
@JustineBoulant JustineBoulant force-pushed the plot_data_distribution branch 2 times, most recently from cf913bd to 44edcfb Compare September 14, 2021 15:27
@bowni
Copy link
Member

bowni commented Sep 17, 2021

Well done @kat-leen great addition to the library for much clearer definition and execution of scenarios 👍

@bowni bowni merged commit 4af1f26 into master Sep 17, 2021
@bowni bowni deleted the plot_data_distribution branch September 17, 2021 08:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Approximation of amounts_per_partner
4 participants