Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add deployment instructions for cipher and card validation projects #1152

Conversation

gabrieluizramos
Copy link
Contributor

Uno de los majores problemas con los proyectos iniciales (cipher & card-validation) para las estudiantes de SAP-007 fueron las instrucciones de como hacer lo deploy de lo proyecto.

Este PR adiciona una secion en los READMEs con instruciones.

@gabrieluizramos gabrieluizramos force-pushed the cipher-and-card-deployment-instructions branch 2 times, most recently from 70cddda to 86fecf2 Compare February 10, 2022 14:17
@JulianaAmoasei
Copy link
Contributor

@gabrieluizramos há versões em pt-br e em es do link:
https://docs.github.com/pt/pages
https://docs.github.com/es/pages

Talvez valha a pena mesmo se estiver incompleta...

@gabrieluizramos gabrieluizramos force-pushed the cipher-and-card-deployment-instructions branch from 86fecf2 to e69afe9 Compare February 10, 2022 19:57
@mfdebian mfdebian self-requested a review March 1, 2022 19:55
@mfdebian mfdebian self-assigned this Mar 1, 2022
@mfdebian mfdebian added the idea Ideas, sugerencias, comentarios generales y feedback label Mar 1, 2022
@lupomontero lupomontero added this to the v5.1.0 milestone Mar 21, 2022
@mfdebian mfdebian removed this from the v5.1.0 milestone May 16, 2022
projects/01-card-validation/README.md Outdated Show resolved Hide resolved
projects/01-cipher/README.md Outdated Show resolved Hide resolved
gabrieluizramos and others added 3 commits July 20, 2022 16:55
Co-authored-by: Alfredo González <12631491+mfdebian@users.noreply.github.com>
Co-authored-by: Alfredo González <12631491+mfdebian@users.noreply.github.com>
@gabrieluizramos gabrieluizramos requested a review from mfdebian July 20, 2022 19:55
Copy link
Collaborator

@mfdebian mfdebian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gabrieluizramos Com essas mudanças já devem passar nos testes!

projects/01-card-validation/README.md Outdated Show resolved Hide resolved
projects/01-cipher/README.md Outdated Show resolved Hide resolved
@mfdebian mfdebian added this to the v5.3.0 milestone Aug 8, 2022
@mfdebian mfdebian merged commit 4965563 into Laboratoria:main Aug 8, 2022
@mfdebian
Copy link
Collaborator

mfdebian commented Aug 8, 2022

Muito obrigado @gabrieluizramos!! 🤘 o PR já foi mergeado.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
idea Ideas, sugerencias, comentarios generales y feedback
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants