Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cambios el readme de Card Validation para ser parecido de Cipher #1243

Merged

Conversation

unjust
Copy link
Contributor

@unjust unjust commented Oct 17, 2022

Hicimos algunos cambios de Cipher, que es Proyecto 1 como Card Validation. Seria bueno si los dos readmes tienen la misma formato y partes, solo la tema es diferente.

  • Agregamos un parte de Objetivos Generales
  • Agregamos un checklist de Considerar Project Feedback
  • Estandarizamos el formato de descripción de archivos, boilerplate etc para coincidir con cipher

Aqui es el preview de README en es y pt

@unjust unjust linked an issue Oct 17, 2022 that may be closed by this pull request
@unjust unjust self-assigned this Oct 18, 2022
@lupomontero lupomontero added enhancement New feature or request content Relacionado al contenido de proyectos y tópicos labels Oct 27, 2022
* [5. Critérios mínimos de aceitação do
projeto](#5-criterios-de-aceptacao-mínimos-do-projeto)
* [6. Guias, dicas e leituras
* [3. Considerações gerais](#3-considerações-gerais)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfecto, la traducción fue genial.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow! Gracias Sr Google :)

Copy link
Member

@moniyama moniyama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fiz duas pequenas sugestões (arrumando links)
e um comentário em ### Primeiros Passos

de resto, LGTM! Gracias @unjust

projects/01-card-validation/README.pt-BR.md Outdated Show resolved Hide resolved
projects/01-card-validation/README.pt-BR.md Outdated Show resolved Hide resolved
projects/01-card-validation/README.pt-BR.md Show resolved Hide resolved
unjust and others added 3 commits November 7, 2022 16:22
Co-authored-by: Monica Yamazaki <52083679+moniyama@users.noreply.github.com>
Co-authored-by: Monica Yamazaki <52083679+moniyama@users.noreply.github.com>
Copy link
Collaborator

@merunga merunga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gracias @unjust por este esfuerzo.
Sólo me hace ruido como hablamos de deploy sin mayor contexto

projects/01-card-validation/README.md Outdated Show resolved Hide resolved
Los metódos de `validator` (`isValid` y `maskify`) deben tener cobertura con
pruebas unitarias.

**3. Código de tu proyecto subido a tu repo y interfaz "desplegada".**
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
**3. Código de tu proyecto subido a tu repo y interfaz "desplegada".**
**3. Código de tu proyecto subido a tu repo y interfaz "accesible públicamente online".**

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No se si desplegada es el mejor término para esta etapa del aprendizaje

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agregue como parentesis abajo en la explanación. No tuvimos preguntas del termino en DEV001.

HTML y CSS. Mientras desarrollas este proyecto, te familiarizarás con nuevos
conceptos también.

### Los objetivos generales de este proyecto son los siguientes
Copy link
Collaborator

@merunga merunga Nov 10, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aqui esta como sección, pero en cipher esta como subseccion de resumen del proyecto

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pruebas unitarias).
* Aprender sobre objetos, estructuras, métodos e iteración (bucles)
en JavaScript
* Implementar control de versiones con git (y la plataforma github)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Algo relacionado a testing? 🙏

Copy link
Contributor Author

@unjust unjust Nov 10, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

esta arriba en

* Conocer las herramientas de mantenimiento y mejora del código (linters y
  pruebas unitarias).

projects/01-card-validation/README.md Outdated Show resolved Hide resolved
unjust and others added 7 commits November 10, 2022 09:52
…:unjust/bootcamp into estandarizar_readme_card_validation_1234
Co-authored-by: Mariano Crowe <merunga@gmail.com>
link relativo

Co-authored-by: Mariano Crowe <merunga@gmail.com>
…:unjust/bootcamp into estandarizar_readme_card_validation_1234
@unjust
Copy link
Contributor Author

unjust commented Nov 10, 2022

@merunga @moniyama Gracias por los comentarios. @moniyama creo arregle el parte de 8 pasos y video.
@merunga tome algunos de tus commits y hice un cambio para explicar desplegada. Dime si hay mas o por favor aprueba :)

Copy link
Member

@moniyama moniyama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@unjust unjust merged commit 8381673 into Laboratoria:main Nov 10, 2022
@unjust unjust deleted the estandarizar_readme_card_validation_1234 branch September 14, 2023 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content Relacionado al contenido de proyectos y tópicos enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Estandarizar el readme de Card Validation para ser parecido de Cipher
5 participants