-
Notifications
You must be signed in to change notification settings - Fork 461
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cambios el readme de Card Validation para ser parecido de Cipher #1243
Cambios el readme de Card Validation para ser parecido de Cipher #1243
Conversation
* [5. Critérios mínimos de aceitação do | ||
projeto](#5-criterios-de-aceptacao-mínimos-do-projeto) | ||
* [6. Guias, dicas e leituras | ||
* [3. Considerações gerais](#3-considerações-gerais) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perfecto, la traducción fue genial.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wow! Gracias Sr Google :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fiz duas pequenas sugestões (arrumando links)
e um comentário em ### Primeiros Passos
de resto, LGTM! Gracias @unjust
Co-authored-by: Monica Yamazaki <52083679+moniyama@users.noreply.github.com>
Co-authored-by: Monica Yamazaki <52083679+moniyama@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Gracias @unjust por este esfuerzo.
Sólo me hace ruido como hablamos de deploy sin mayor contexto
Los metódos de `validator` (`isValid` y `maskify`) deben tener cobertura con | ||
pruebas unitarias. | ||
|
||
**3. Código de tu proyecto subido a tu repo y interfaz "desplegada".** |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
**3. Código de tu proyecto subido a tu repo y interfaz "desplegada".** | |
**3. Código de tu proyecto subido a tu repo y interfaz "accesible públicamente online".** |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No se si desplegada es el mejor término para esta etapa del aprendizaje
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agregue como parentesis abajo en la explanación. No tuvimos preguntas del termino en DEV001.
HTML y CSS. Mientras desarrollas este proyecto, te familiarizarás con nuevos | ||
conceptos también. | ||
|
||
### Los objetivos generales de este proyecto son los siguientes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Aqui esta como sección, pero en cipher esta como subseccion de resumen del proyecto
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pruebas unitarias). | ||
* Aprender sobre objetos, estructuras, métodos e iteración (bucles) | ||
en JavaScript | ||
* Implementar control de versiones con git (y la plataforma github) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Algo relacionado a testing? 🙏
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
esta arriba en
* Conocer las herramientas de mantenimiento y mejora del código (linters y
pruebas unitarias).
…:unjust/bootcamp into estandarizar_readme_card_validation_1234
Co-authored-by: Mariano Crowe <merunga@gmail.com>
link relativo Co-authored-by: Mariano Crowe <merunga@gmail.com>
…:unjust/bootcamp into estandarizar_readme_card_validation_1234
@merunga @moniyama Gracias por los comentarios. @moniyama creo arregle el parte de 8 pasos y video. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀
Hicimos algunos cambios de Cipher, que es Proyecto 1 como Card Validation. Seria bueno si los dos readmes tienen la misma formato y partes, solo la tema es diferente.
Aqui es el preview de README en es y pt