Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Final update of new project for UX curricula. #1342

Merged
merged 7 commits into from
Mar 27, 2023

Conversation

lisperaza
Copy link
Contributor

No description provided.

@mfdebian mfdebian added this to the v6.2.0 milestone Mar 22, 2023
@mfdebian mfdebian self-assigned this Mar 22, 2023
Copy link
Collaborator

@mfdebian mfdebian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

La única razón por la cual no pasan los test, es porque , en primer lugar, ahora (de hace poco, de la v6.0.0 en adelante) en el archivo project.yml se le agrega en la primera línea el track al que pertenece el proyecto, en este caso el cambio que propongo es agregar track: ux al comienzo de cada uno de ellos; y en segundo lugar, es porque el directorio 02-UXploradora debería estar todo en minúsculas, con esos cambios ya debería pasar los tests!

@@ -0,0 +1,14 @@
learningObjectives:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
learningObjectives:
track: ux
learningObjectives:

@@ -0,0 +1,40 @@
learningObjectives:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
learningObjectives:
track: ux
learningObjectives:

Copy link
Collaborator

@mfdebian mfdebian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ⭐

@mfdebian mfdebian merged commit 089cee9 into Laboratoria:main Mar 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants