Readme mdLinks con hitos #1375
Merged
Readme mdLinks con hitos #1375
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
unjust
reviewed
May 12, 2023
Davichobits
changed the title
Davichobits
force-pushed
the
david-ruiz-mdlinks-#1371
branch
from
6125961 to
0c8e903
Compare
unjust
reviewed
Jun 15, 2023
unjust
reviewed
Jun 15, 2023
unjust
reviewed
Jun 15, 2023
unjust
reviewed
Jun 15, 2023
unjust
reviewed
Jun 15, 2023
unjust
reviewed
Jun 15, 2023
unjust
reviewed
Jun 15, 2023
|
Una pregunta que tengo es si ponemos todos los Hitos en el README asi, o si mencionamos los hitos en el README y linkearlo a un archivo milestones.md que explica todo eso. Otro es si quiza el Hito de CLI movimos antes de Hito de recursividad ❓ Que piensan @Davichobits @DeysiVergara @Adrian0617 ? |
unjust
added
enhancement
merunga
reviewed
Jun 16, 2023
There was a problem hiding this comment.
Gracias @Davichobits por este trabajo.
Comentarios:
- debemos elegir un termino unico para referirnos al modulo: o bien libreria o bien biblioteca, pero creo q puede confundir un poco usarlas de manera indistinta
- todas los textos q hacen referencia a codigo, deberia estar formateado como tal, por ejemplo
new Promise() - creo q el readme está muy largo. @unjust creo q podemos avanzar asi, pero apuntaría a un nuevo issue donde en el README solo se detalla el problema, y que las guías de cómo atacar cada hito estuvieran fuera
- creo q es importante hacer un mdlint de manera temprana antes de mandar el PR
Co-authored-by: Mariano Crowe <merunga@gmail.com>
unjust
reviewed
Jul 21, 2023
unjust
reviewed
Jul 21, 2023
unjust
reviewed
Jul 21, 2023
unjust
reviewed
Jul 21, 2023
unjust
reviewed
Jul 21, 2023
unjust
reviewed
Jul 21, 2023
unjust
reviewed
Jul 21, 2023
unjust
reviewed
Jul 21, 2023
unjust
reviewed
Jul 21, 2023
unjust
reviewed
Jul 21, 2023
unjust
reviewed
Jul 21, 2023
unjust
reviewed
Jul 21, 2023
unjust
reviewed
Jul 21, 2023
unjust
reviewed
Jul 21, 2023
unjust
reviewed
Jul 21, 2023
unjust
reviewed
Jul 21, 2023
unjust
reviewed
Jul 21, 2023
unjust
reviewed
Jul 21, 2023
unjust
reviewed
Jul 21, 2023
unjust
reviewed
Jul 21, 2023
unjust
reviewed
Jul 21, 2023
unjust
reviewed
Jul 22, 2023
unjust
reviewed
Jul 22, 2023
unjust
approved these changes
Jul 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #1371
Por favor lee el issue ☝️ para tener contexto de esos cambios.
Agregamos Hitos al proyecto para romper el proyecto en entregables de API y el CLI.
Seria bueno ver la totalidad de README y avisar si algo no tiene sentido con el contexto.