Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Text Analyzer README in Portuguese #1537

Merged
merged 8 commits into from
Aug 28, 2023
Merged

Add Text Analyzer README in Portuguese #1537

merged 8 commits into from
Aug 28, 2023

Conversation

ChristianRL23
Copy link
Contributor

  • Se hizo una revisión completa de que todo estuviera en portugués y con la misma estructura del .md original.
  • Se revisó cada uno de los links que habían y se actualizaron algunos a recursos en portugués.

unjust
unjust suggested changes Aug 24, 2023
View reviewed changes
Copy link
Contributor

@unjust unjust left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Diria que hacimos los cambios a los tests en otra rama, es un issue aparte
https://github.com/Laboratoria/bootcamp/issues/1533

Y los cambios seria en el mismo analyzer.spec.js (no en.js, me gusta la idea pero por ahora hacer los cambios en el spec original.)

unjust
unjust reviewed Aug 25, 2023
View reviewed changes
Copy link
Contributor

@unjust unjust left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sin el "diff" de como fue analyzer.spec.js anterior - al menos el ingles me parece bien, solo un comentario. Pero cuando hay el diff (no creamos nuevo spec.en pero solo aplicamos los cambios a spec.js) puedo ver mejor la traduccion de antes/despues

projects/01-text-analyzer/test/analyzer.spec.en.js Outdated Show resolved Hide resolved
@ChristianRL23 ChristianRL23 requested a review from unjust August 25, 2023 16:30
unjust
unjust previously approved these changes Aug 25, 2023
View reviewed changes
Copy link
Contributor

@unjust unjust left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! solo hay que corregir los mdlint errores.

This was linked to issues Aug 25, 2023
Text Analyzer traducido en PT #1384
Closed
Text Analyzer tests traducido en pt (descripciones etc) #1533
Closed
@unjust
Copy link
Contributor

unjust commented Aug 26, 2023 •
edited
Loading

Por favor @ChristianRL23 integrar estes cambios a tu rama https://github.com/ChristianRL23/bootcamp/pull/1/files
Y de ahi puedes conseguir otra approval de un reviewer y hacer el merge.

unjust
unjust approved these changes Aug 28, 2023
View reviewed changes
Copy link
Contributor

@unjust unjust left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gracias por corregir los de mdlint.

@unjust unjust merged commit 8c6459f into Laboratoria:next Aug 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@unjust unjust unjust approved these changes

@MaferAlmeida MaferAlmeida Awaiting requested review from MaferAlmeida

Assignees

@ChristianRL23 ChristianRL23

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Text Analyzer tests traducido en pt (descripciones etc) Text Analyzer traducido en PT
3 participants
@ChristianRL23 @unjust @MaferAlmeida