Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add titles and links for some oas typescript #1556

Merged
merged 5 commits into from
Sep 5, 2023

Conversation

unjust
Copy link
Contributor

@unjust unjust commented Sep 5, 2023

Fixes #1508

@unjust unjust self-assigned this Sep 5, 2023
@unjust unjust added the bug Error que necesita arreglo label Sep 5, 2023
@unjust unjust requested review from merunga and mfdebian September 5, 2023 19:31
@unjust unjust linked an issue Sep 5, 2023 that may be closed by this pull request
Copy link
Collaborator

@mfdebian mfdebian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sólo un pequeño cambio en una URL y con eso queda listo para ser mergado 🥳

Gracias @unjust !!

learning-objectives/intl/es.yml Outdated Show resolved Hide resolved
Copy link
Collaborator

@mfdebian mfdebian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ya le di commit nomás a ese pequeño typo en la URL, le daré approve y merge 😊

@mfdebian mfdebian merged commit c217d57 into Laboratoria:next Sep 5, 2023
@mfdebian mfdebian added this to the next release milestone Sep 5, 2023
@unjust unjust deleted the typescript_titles_1508 branch September 5, 2023 20:45
@unjust unjust modified the milestones: next release, 7.1.0 Sep 13, 2023
merunga added a commit to merunga/curriculum that referenced this pull request Sep 22, 2023
* feat(deps): Added Vite

* config: removes duplicate key and adds (for now empty but mut be changed) process.env def

* chore(deps): Updates @laboratoria/react/dist imports to @laboratoria/react/src as per last release

* feat(workflow): Updates env variable examples and updates github ci/cd workflows with new variables - deprecates REACT_APP_ variables and the set-output task

* chore(config): Updates vite config file and @laboratoria/react dependency

* fix(lib): Undo changes to lib/data.js process.env

* chore(deps): Removes react-scripts and webpack config file

* fix(package.json): removes type module

* fix(vite cofig): Adds dotenv() to vite.config file

* chore(deps): Update dependencies and adds dotenv dep

* fix(env/workers): Updates env variables and fixes workers/ symlink

* fix(gh actions): Fixes Laboratoria api urls

* fix(config): Fixes env variable name in Vite config file

* chore(deps): Updates @laboratoria/react dependency with ace editor fixes

* feat(vitest): Adds Vitest, jsdom, test setup in vite.config.js, moves __mocks__ to root dir and fixes components tests

* chore(deps): Removes unused Jest config

* fix(test): Fixes Topic test in node 20

* chore(docs): Actualiza todas las referencias antiguas del repo Laboratoria/bootcamp a Laboratoria/curriculum

* chore(release): Bumps version to v7.0.0 and updates dist files

* fix(project docs): Adds thumbnails to UX projects READMEs

* fix(assets): Fixes outdated 01-design-and-usability thumbnail

* feat(sentry): Adds Sentry config function from @laboratoria/react in src/index.jsx and adds the corresponding variable to github actions (Laboratoria#1554)

* fix(yml): add titles and links for some oas typescript (Laboratoria#1556)

* fix: add titles and links for some oas typescript

* fix: oas typescript portuguese

* space

* Update learning-objectives/intl/es.yml

* Convert Fleet Management Service Project from fullstack to backend (Laboratoria#1542)

* Convert project from fullstack to backend

* CLI specifications, poor performance by default, pagination

* feat: Adds prompting learning objectives addresses Laboratoria#1510 (Laboratoria#1567)

* adds  prompting OAs and translation en es

* portugues, corrections

* Apply suggestions from code review

Co-authored-by: Alfredo González <12631491+mfdebian@users.noreply.github.com>

* simplify oas

* few shot prompting

* cambia titulos de recursos

* quitar prompting oa de data lovers

* Update learning-objectives/intl/es.yml

Co-authored-by: David Ruiz <123121338+Davichobits@users.noreply.github.com>

---------

Co-authored-by: Alfredo González <12631491+mfdebian@users.noreply.github.com>
Co-authored-by: David Ruiz <123121338+Davichobits@users.noreply.github.com>

* chore(release): Bumps version to v7.1.0 and updates dist files

* fix: Reemplazar create react app, fixes Laboratoria#1453 (Laboratoria#1555)

* falta imagen para reemplazar

* imagen react

* sin create-react-app, con imagen

* con creacion de carpeta

* mdlint

* mdlint espacios en heading

* sin coma

* eliminar procedimiento

* eliminar imagen

* espacio debajo de los titulos

* Update projects/04-notes/README.md

Co-authored-by: Ivy Feraco <unjust@gmail.com>

* descripción de linkk

---------

Co-authored-by: Ivy Feraco <unjust@gmail.com>

* fix: cambios con feedback DEV011 - resaltar root, modificar instrucciones Addresses Laboratoria#1577 (Laboratoria#1587)

* resaltar root, modificar instruccion de view

* cambio de instrucciones en dataFunctions, cambiar el console.log para ejecutar las funciones, añadir parametro en view.js

* mejorar instrucciones en dataFunctions

* espacios despues comments

* Quita prototipo de baja, reordenar indice

---------

Co-authored-by: Ivy Feraco <unjust@gmail.com>
Co-authored-by: Ivy Feraco <ivy@laboratoria.la>

* fix: remove extra docs in Dataverse and edit title (Laboratoria#1586)

* remove EXTRA and old data lovers README in pt

* move some resources to main README, delete FAQ

* Apply suggestions from code review, acentos etc.

Co-authored-by: David Ruiz <123121338+Davichobits@users.noreply.github.com>

* Update README.md quita card class

---------

Co-authored-by: David Ruiz <123121338+Davichobits@users.noreply.github.com>

* fix: adds prompting objectives to project.yml (Laboratoria#1585)

---------

Co-authored-by: Alfredo González <alfredo.arosteguy@gmail.com>
Co-authored-by: Alfredo González <12631491+mfdebian@users.noreply.github.com>
Co-authored-by: Ivy Feraco <ivy@laboratoria.la>
Co-authored-by: Sergio Sinuco <ssinuco@gmail.com>
Co-authored-by: David Ruiz <123121338+Davichobits@users.noreply.github.com>
Co-authored-by: ivy <unjust@gmail.com>
Co-authored-by: DeysiVergara <91211248+DeysiVergara@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Error que necesita arreglo
Projects
None yet
Development

Successfully merging this pull request may close these issues.

falta algunos titles de OAs (algunos de typescript)
2 participants