Skip to content

Commit

Permalink
Add type checking to standard tests
Browse files Browse the repository at this point in the history
  • Loading branch information
LachJones committed Oct 27, 2024
1 parent 195b240 commit beee84d
Show file tree
Hide file tree
Showing 3 changed files with 8 additions and 2 deletions.
4 changes: 4 additions & 0 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,10 @@ jobs:
run: |
python -m pip install --upgrade pip
python -m pip install .
- name: Type Checking
run: |
python -m pip install mypy
python -m mypy iso639
- name: Test
run: |
pip install pytest
Expand Down
3 changes: 2 additions & 1 deletion CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -64,9 +64,10 @@ Pushing changes to your forked repository should trigger a [workflow](https://gi
flake8
black --check .
isort --check-only .
mypy iso639
```

`iso639-lang` uses `flake8` for linting, `black` for formatting and `isort` for sorting imports. The configuration of these tools is available in the `.flake8` and `pyproject.toml` files.
`iso639-lang` uses `flake8` for linting, `black` for formatting, `isort` for sorting imports and `mypy` for type checking. The configuration of these tools is available in the `.flake8` and `pyproject.toml` files.


## Submitting Changes
Expand Down
3 changes: 2 additions & 1 deletion requirements-dev.txt
Original file line number Diff line number Diff line change
Expand Up @@ -5,4 +5,5 @@ isort>=5.13.2
lxml>=5.3.0
pandas>=2.0.3
requests>=2.32.3
pytest>=8.3.2
pytest>=8.3.2
mypy>=1.13.0

0 comments on commit beee84d

Please sign in to comment.