Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

flake: Fix a broken dev shell #2450

Merged
merged 3 commits into from
Dec 1, 2024
Merged

Conversation

ttrssreal
Copy link
Contributor

The current flake's devShell tries to import Ladybird which was renamed to UI.

Additionally, many dependencies aren't currently included in the devShell. As ladybird is already packaged downstream, we can pull in those buildInputs along with the extra dev dependencies already defined.
This gets the shell working and ladybird buildable :3

@ttrssreal ttrssreal changed the title Resolve some nix-flake issues flake: Fix a broken dev shell Nov 20, 2024
@ADKaster
Copy link
Member

Thanks for patching the nix shell!

Does this fully resolve this issue then? #371 (comment)

If it does, then a documentation PR to say that the nix build is no longer completely borked would be a good follow-up https://github.com/LadybirdBrowser/ladybird/blob/master/Documentation/BuildInstructionsLadybird.md#nixos-or-with-nix

@ttrssreal
Copy link
Contributor Author

Hi! You can enter the shell and do a normal cmake build and it seems to work fine. Using vcpkg via ./Meta/ladybird.sh run ladybird will fail when bootstrapping but that's expected.

So then there's just removing the Note, changing Ladybird to UI, and telling people to use cmake?

@ttrssreal ttrssreal force-pushed the flake branch 2 times, most recently from 11a6bf0 to 45243a9 Compare November 21, 2024 02:59
@timschumi
Copy link
Member

Looks like vcpkg bootstrapping is still borked, but reading the comments that seems to be expected.

Updating the documentation surrounding the Nix build would be great, since I currently have no idea on how to test this.

@ttrssreal
Copy link
Contributor Author

Okie sounds good, you should be able to run nix develop and then cmake build like normal cmake -GNinja -BBuild.

@timschumi
Copy link
Member

Ok, looks good to me once we get the documentation in order.

Many dependencies aren't currently included in the devShell. As ladybird
is already packaged downstream, we can pull in those buildInputs along
with the extra dev dependencies already defined.
@ADKaster ADKaster merged commit f4cc9c6 into LadybirdBrowser:master Dec 1, 2024
5 of 6 checks passed
@ttrssreal
Copy link
Contributor Author

yay :3, do we close #371 then?

@ttrssreal ttrssreal deleted the flake branch December 14, 2024 09:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants