-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
flake: Fix a broken dev shell #2450
Conversation
Thanks for patching the nix shell! Does this fully resolve this issue then? #371 (comment) If it does, then a documentation PR to say that the nix build is no longer completely borked would be a good follow-up https://github.com/LadybirdBrowser/ladybird/blob/master/Documentation/BuildInstructionsLadybird.md#nixos-or-with-nix |
Hi! You can enter the shell and do a normal cmake build and it seems to work fine. Using vcpkg via So then there's just removing the Note, changing Ladybird to UI, and telling people to use cmake? |
11a6bf0
to
45243a9
Compare
Looks like Updating the documentation surrounding the Nix build would be great, since I currently have no idea on how to test this. |
Okie sounds good, you should be able to run |
Ok, looks good to me once we get the documentation in order. |
Many dependencies aren't currently included in the devShell. As ladybird is already packaged downstream, we can pull in those buildInputs along with the extra dev dependencies already defined.
yay :3, do we close #371 then? |
The current flake's devShell tries to import
Ladybird
which was renamed toUI
.Additionally, many dependencies aren't currently included in the devShell. As ladybird is already packaged downstream, we can pull in those buildInputs along with the extra dev dependencies already defined.
This gets the shell working and ladybird buildable :3