-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow user to exclude locations #389
base: master
Are you sure you want to change the base?
Conversation
I've added 10 tests that hopefully cover a sufficient number of setting combos to test this feature. |
test/test_dry.py
Outdated
@@ -41,6 +42,8 @@ def enable_all_progression_location_options(options: Options): | |||
|
|||
def enable_all_options(options: Options): | |||
enable_all_progression_location_options(options) | |||
# options.progression_locations | |||
# options.excluded_locations |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did you mean to leave these comments in?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, I figured it was in the style of the test function to have all the options there, but the unmodified ones commented out. Like with randomized_gear
/starting_gear
.
I got an error when running the Windows build: |
I fixed the pkg error on master, you can revert the workaround in wwrando.spec |
b8b0ea0
to
8920d90
Compare
8920d90
to
23bfee2
Compare
23bfee2
to
5e8e279
Compare
This PR adds a new tab to the randomizer called "Excluded Locations", which allows users to specify that the randomizer should ignore particular locations for progression.
The interface here is similar to selecting starting items from randomized items. On the "Excluded Locations" tab, the user can view all the progression locations for the settings selected from the main tab. They can use the buttons to move locations to the "Excluded Locations" side; locations here will be considered nonprogress locations by the randomizer.
A few things to note:
I've also included a change to use
zlib
compression in addition tobase64
encoding for permalinks. This is not necessary but since the bitstring will contain an additional bit for every location, it becomes rather long. For the default settings and a seed name ofA
:Before:
MS4xMC4wX2Y4NjM0ZDAAQQBJEFAAAAAAAACA/NwFAAAAAAAAAAAAAAIAAAAAAgAQQAAAAAAAAAAAAAAAGAAA+wLoEgAAAAAIAAQBAAI=
After:
eJwz1DM00DOIT7MwMzZJMWBwZPAUCGAAg4Y/d1gZ4IAJQgg4IIQYJBgYfjO9EAIxORhYGBmYALjbCQY=
If any other changes are necessary, let me know!