New rocAL python API #9
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
swetha097
commented
Oct 22, 2021
swetha097
commented
- Augmentation App
- coco pipeline
- caffe, caffe2 pipelines for classification & detection
- tf classification & detection pipeline
- python rali unit test
Fix convolotion issue for hip
fix seg fault for ScaleGaussian
Add support for channelCopy, Lut, UV12/UV/IUV format converts and ScaleUp2x2 in Color kernels
Optimize statistical kernels
…etic/logical/color/filter/statistical kernels
Add kernelGDFs, enhance test scripts - runVisionTests.py and runvxTestAllScript.sh
Test suite fixes
…/MIVISION into box_encoder_changes_v0.2
…te-Libraries/MIVisionX into box_encoder_changes_v0.2
…te-Libraries/MIVisionX into new_rocAL_python_API
LakshmiKumar23
requested changes
Oct 22, 2021
There was a problem hiding this comment.
@swetha097 I also see a couple of empty files. Are they needed?
rocAL/rocAL/source/master_graph.cpp
Outdated
| @@ -17,7 +17,7 @@ FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE | |||
| AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER | |||
| LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, | |||
| OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN | |||
| THE SOFTWARE. | |||
| THE SOFTWARE.lround | |||
There was a problem hiding this comment.
@swetha097 Can you check what this is. Seems like a typo?
There was a problem hiding this comment.
I think its a typo Lakshmi.
Removed it
| @@ -655,6 +655,7 @@ raliJpegCOCOFileSourceSingleShard( | |||
| unsigned max_width, | |||
| unsigned max_height) | |||
| { | |||
| std::cout<<"\n COMES TO COCOFILESOURCESINGLESHARD"; | |||
There was a problem hiding this comment.
@swetha097 Do we need the debug statements? Same above?
rrawther
reviewed
Oct 22, 2021
| @@ -478,6 +478,10 @@ raliBrightness( | |||
| RaliFloatParam p_alpha, | |||
| RaliFloatParam p_beta) | |||
| { | |||
| std::cerr<<"\n**************************************************************************"; | |||
There was a problem hiding this comment.
I think this should be removed
rrawther
reviewed
Oct 22, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.