Update to 1.20 #156

Lisixo · 2023-06-10T02:21:55Z

Updated to Minecraft 1.20

I commented gui/SettingsScreen.java because i can't find solution for this code fragment but mod and game work fine without this code fragment

Kichura

Tested this under a clean fabric instance and it seems to work just fine, not sure what the fillGradient in settings screen system was for though.

Lisixo · 2023-06-10T14:39:11Z

fillGradient adds black shadow to settings background

Latest 1.19.4 build:

1.20 build:

Oliver-makes-code

Mojang doesn't pass MatixStacks in gui anymore, they use a class called GuiGraphics, which contains the stuff needed.

Oliver-makes-code · 2023-06-10T16:17:32Z

src/main/java/dev/lambdaurora/lambdynlights/gui/SettingsScreen.java

 		container.setBackground((matrices, widget, vOffset, mouseX, mouseY, delta) -> {
 			if (this.client.world != null) {
-				this.fillGradient(matrices, widget.getX(), widget.getY(),
-						widget.getX() + widget.getWidth(), innerWidget.getY(),
-						0xc0101010, 0xd0101010);
-				this.fillGradient(matrices, widget.getX(), innerWidget.getY() + innerWidget.getHeight(),
-						widget.getX() + widget.getWidth(), widget.getY() + widget.getHeight(),
-						0xc0101010, 0xd0101010);
+				// Commented because i can't find a solution
+
+//				this.fillGradient(matrices, widget.getX(), widget.getY(),
+//						widget.getX() + widget.getWidth(), innerWidget.getY(),
+//						0xc0101010, 0xd0101010);
+//				this.fillGradient(matrices, widget.getX(), innerWidget.getY() + innerWidget.getHeight(),
+//						widget.getX() + widget.getWidth(), widget.getY() + widget.getHeight(),
+//						0xc0101010, 0xd0101010);


Suggested change

container.setBackground((matrices, widget, vOffset, mouseX, mouseY, delta) -> {

if (this.client.world != null) {

this.fillGradient(matrices, widget.getX(), widget.getY(),

widget.getX() + widget.getWidth(), innerWidget.getY(),

0xc0101010, 0xd0101010);

this.fillGradient(matrices, widget.getX(), innerWidget.getY() + innerWidget.getHeight(),

widget.getX() + widget.getWidth(), widget.getY() + widget.getHeight(),

0xc0101010, 0xd0101010);

// Commented because i can't find a solution

// this.fillGradient(matrices, widget.getX(), widget.getY(),

// widget.getX() + widget.getWidth(), innerWidget.getY(),

// 0xc0101010, 0xd0101010);

// this.fillGradient(matrices, widget.getX(), innerWidget.getY() + innerWidget.getHeight(),

// widget.getX() + widget.getWidth(), widget.getY() + widget.getHeight(),

// 0xc0101010, 0xd0101010);

container.setBackground((graphics, widget, vOffset, mouseX, mouseY, delta) -> {

if (this.client.world != null) {

graphics.fillGradient(widget.getX(), widget.getY(),

widget.getX() + widget.getWidth(), innerWidget.getY(),

0xc0101010, 0xd0101010);

graphics.fillGradient(widget.getX(), innerWidget.getY() + innerWidget.getHeight(),

widget.getX() + widget.getWidth(), widget.getY() + widget.getHeight(),

0xc0101010, 0xd0101010);

This should be what you need

Thank you. Now everything should be fine

Rubyboat1207 · 2023-06-16T23:57:18Z

This works in 1.20.1, someone needs to update the mod.json though

joestr · 2023-06-17T15:32:33Z

Confirmed working on 1.20.1

mk-pmb · 2023-06-17T16:47:58Z

Can confirm, works for me for 1.20. This is my build including a JAR download for anyone else who needs one.

@Lisixo Thanks a lot!

PetyXbron · 2023-06-17T19:15:02Z

Hey @Lisixo, could this PR also support Minecraft v1.20.1?

mk-pmb · 2023-06-17T19:47:53Z

Thanks @KennyDevT ! I restarted my build. The new JAR for 1.20.1 should be public in about 10 minutes.
Edit: The new download has arrived.

KennyDevT · 2023-06-17T19:57:07Z

Honestly I just wanted to have it in my modpack I didn't even know about this PR until I decided to PR it to Lixiso fork

JanLukasGithub · 2023-06-18T18:57:02Z

Now we just need @LambdAurora (or someone else with rights to do so) to merge this and update the modrinth page, right?

mk-pmb · 2023-06-19T00:32:18Z

@JanLukasGithub I think we should wait for more people to report whether it worked for them in 1.20.1. I myself only play 1.20 currently, and I haven't seen any confirmation comments for the current commit fea5d26 .

Update: fea5d26 JAR download if someone needs it. React with 🚀 if it works for you in MC 1.20.1.

TheUnknownCod3r · 2023-06-20T00:42:57Z

I know this is closed and published now, but Fabric API should be 0.83.0 if people are still using base 1.20, as most mod launchers will still serve it as the most recent version for 1.20.

LambdAurora · 2023-06-20T00:44:58Z

Well, that's one issue I just realized I forgot.
The dependency should also be marked fabric-api now... oops...

Welp, I'm not fixing that now, worst case scenario there's dependency overrides, and 1.20.1 is so minor everything should work there anyway so people should just update.

MBCMechachu · 2023-06-20T04:20:39Z

That's a tad unfortunate. I was kind of hoping to use the mod in 1.20.0 but each time I loaded it in with my other mods I kept getting this message.

Replace mod 'Fabric API' (fabric-api) 0.83.0+1.20 with mod 'Fabric API' (fabric-api), version 0.83.1+1.20.1 or later.

Mod 'LambDynamicLights' (lambdynlights) 2.3.1+1.20.1 requires version 0.83.1+1.20.1 or later of mod 'Fabric API'
(fabric-api), but only the wrong version is present: 0.83.0+1.20!

LambdAurora · 2023-06-20T08:40:12Z

@MBCMechachu update to 1.20.1 and update Fabric API.

1.20.1 is so minor that all mods should work and be compatible with 1.20 servers.

TheUnknownCod3r · 2023-06-20T12:55:45Z

That's a tad unfortunate. I was kind of hoping to use the mod in 1.20.0 but each time I loaded it in with my other mods I kept getting this message.

Replace mod 'Fabric API' (fabric-api) 0.83.0+1.20 with mod 'Fabric API' (fabric-api), version 0.83.1+1.20.1 or later.

Mod 'LambDynamicLights' (lambdynlights) 2.3.1+1.20.1 requires version 0.83.1+1.20.1 or later of mod 'Fabric API'
(fabric-api), but only the wrong version is present: 0.83.0+1.20!

You can create an overrides pack to bypass that, follow https://fabricmc.net/wiki/tutorial:dependency_overrides and just set it up for dynamic lights, or update to 1.20.1, and just copy paste everything, as it should work anyway.

MBCMechachu · 2023-06-21T04:52:46Z

That's a tad unfortunate. I was kind of hoping to use the mod in 1.20.0 but each time I loaded it in with my other mods I kept getting this message.
Replace mod 'Fabric API' (fabric-api) 0.83.0+1.20 with mod 'Fabric API' (fabric-api), version 0.83.1+1.20.1 or later.
Mod 'LambDynamicLights' (lambdynlights) 2.3.1+1.20.1 requires version 0.83.1+1.20.1 or later of mod 'Fabric API'
(fabric-api), but only the wrong version is present: 0.83.0+1.20!

You can create an overrides pack to bypass that, follow https://fabricmc.net/wiki/tutorial:dependency_overrides and just set it up for dynamic lights, or update to 1.20.1, and just copy paste everything, as it should work anyway.

A lot of this is far too complex for me to understand in order for me to do this on my own. What's worse is that I can't seem to find any sort of step by step videos anywhere so I'm just stuck having to wait until the mods I was using update to 1.20.1; assuming that some of them do at all.

Update: Turns out all I needed to do was update my Fabric API to the one for 1.20.1, everything is working fine now.

mk-pmb · 2023-06-21T13:19:08Z

Can we have the v2.3.1+1.20.1 release page have a big hint "You'll need to update Fabric API to at least x.x.x" also with a download link to that?

Edit: Maybe it would be a good idea to have a default "System Requirements" chapter as one of the first things on every release page.

Update to 1.20

2c4bdff

Kichura reviewed Jun 10, 2023

View reviewed changes

Oliver-makes-code suggested changes Jun 10, 2023

View reviewed changes

Fixed background for SettingsScreen

7a82736

Repository owner deleted a comment from jhmaster2000 Jun 12, 2023

mk-pmb mentioned this pull request Jun 17, 2023

Update to 1.20 #154

Closed

Update to 1.20.1 (#3)

c4829df

Add range to support 1.20.x

fea5d26

LambdAurora changed the base branch from 1.19.4 to 1.20 June 19, 2023 22:46

Merge branch '1.20' into 1.20

743aeb1

LambdAurora merged commit 3f8a0c4 into LambdAurora:1.20 Jun 19, 2023

5HT2 mentioned this pull request Jun 22, 2023

bump: Update to Minecraft 1.19.4 (#144). #144

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update to 1.20 #156

Update to 1.20 #156

Lisixo commented Jun 10, 2023

Kichura left a comment

Lisixo commented Jun 10, 2023

Oliver-makes-code left a comment

Oliver-makes-code Jun 10, 2023

Lisixo Jun 10, 2023

Rubyboat1207 commented Jun 16, 2023

joestr commented Jun 17, 2023

mk-pmb commented Jun 17, 2023 •

edited

Loading

PetyXbron commented Jun 17, 2023

mk-pmb commented Jun 17, 2023 •

edited

Loading

KennyDevT commented Jun 17, 2023 •

edited

Loading

JanLukasGithub commented Jun 18, 2023

mk-pmb commented Jun 19, 2023 •

edited

Loading

TheUnknownCod3r commented Jun 20, 2023

LambdAurora commented Jun 20, 2023

MBCMechachu commented Jun 20, 2023 •

edited

Loading

LambdAurora commented Jun 20, 2023

TheUnknownCod3r commented Jun 20, 2023

MBCMechachu commented Jun 21, 2023 •

edited

Loading

mk-pmb commented Jun 21, 2023 •

edited

Loading

Update to 1.20 #156

Update to 1.20 #156

Conversation

Lisixo commented Jun 10, 2023

Kichura left a comment

Choose a reason for hiding this comment

Lisixo commented Jun 10, 2023

Oliver-makes-code left a comment

Choose a reason for hiding this comment

Oliver-makes-code Jun 10, 2023

Choose a reason for hiding this comment

Lisixo Jun 10, 2023

Choose a reason for hiding this comment

Rubyboat1207 commented Jun 16, 2023

joestr commented Jun 17, 2023

mk-pmb commented Jun 17, 2023 • edited Loading

PetyXbron commented Jun 17, 2023

mk-pmb commented Jun 17, 2023 • edited Loading

KennyDevT commented Jun 17, 2023 • edited Loading

JanLukasGithub commented Jun 18, 2023

mk-pmb commented Jun 19, 2023 • edited Loading

TheUnknownCod3r commented Jun 20, 2023

LambdAurora commented Jun 20, 2023

MBCMechachu commented Jun 20, 2023 • edited Loading

LambdAurora commented Jun 20, 2023

TheUnknownCod3r commented Jun 20, 2023

MBCMechachu commented Jun 21, 2023 • edited Loading

mk-pmb commented Jun 21, 2023 • edited Loading

mk-pmb commented Jun 17, 2023 •

edited

Loading

mk-pmb commented Jun 17, 2023 •

edited

Loading

KennyDevT commented Jun 17, 2023 •

edited

Loading

mk-pmb commented Jun 19, 2023 •

edited

Loading

MBCMechachu commented Jun 20, 2023 •

edited

Loading

MBCMechachu commented Jun 21, 2023 •

edited

Loading

mk-pmb commented Jun 21, 2023 •

edited

Loading