added dynamic lighting for the glowing effect to entities and dropped/held spectral arrows #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… / held spectral arrows
|
Sorry, latest commit broke the PR, now items luminance are JSON files, I appreciate the PR nonetheless ;) |
|
np i did it as something i wanted to do tbh i was originally not going to
PR so it's all good
<https://www.avast.com/sig-email?utm_medium=email&utm_source=link&utm_campaign=sig-email&utm_content=webmail>
Virus-free.
www.avast.com
<https://www.avast.com/sig-email?utm_medium=email&utm_source=link&utm_campaign=sig-email&utm_content=webmail>
<#DAB4FAD8-2DD7-40BB-A1B8-4E2AA1F9FDF2>
…On Sat, Aug 15, 2020 at 2:14 PM LambdAurora ***@***.***> wrote:
Sorry, latest commit broke the PR, now items luminance are JSON files, I
appreciate the PR nonetheless ;)
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#17 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AQT5ACZE5Q3YWOINGQJB6FLSA2C2RANCNFSM4QAIKDHQ>
.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I wanted to do this because i thought it would be more accurate if the glowing effect and spectral arrows when dropped and held emits light like when spectral arrows are shot. When an entity is shot with a spectral arrow it glows.